[Bug 228409] export package as spi

  • From:
  • To:
  • Subject: [Bug 228409] export package as spi
  • Date: Thu, 11 Apr 2013 06:30:28 +0000
  • Auto-submitted: auto-generated

http://netbeans.org/bugzilla/show_bug.cgi?id=228409

--- Comment #5 from Milos Kleint 
< >
 2013-04-11 06:30:28 UTC ---
(In reply to comment #4)
> TZ01: The api.java is not project aware it should not contain any project
> related API. You want to use java.project or java.api.common depending on 
> the
> stability of the proposed API.
> 
> TZ02: The api.java should not contain any UI.

TZ01-02 Ok, I've suggested it to mkozeny, given that AccessibilityQuery is in
the same module and that it's current clients have api.java as common
denominator. But moving it elsewhere (both API and the UI is probably ok)

> 
> TZ03: The name of the interface is probably not very good as it has not 
> much in
> common with its purpose. The ProjectModifierImplementation is very general.
> 

+1
my suggestion is to include Export, Public, Package, Accessibility, Modifier,
Handler words maybe or their combination. 


MK1: apichanges entry should not include notes on implementation, just the
contract

MK2: implementation wise - Project project =
FileOwnerQuery.getOwner(selectedPackages.iterator().hasNext()?selectedPackages.iterator().next():null);
is not a good pattern IMHO, we should either guard against selecting packages
from multiple projects or deal with multiple implementation instances
simultaneously

MK3 (for optional consideration). The word "export" is likely associated with
OSGI, in netbeans module system it's not as widely used, maybe the API shoudl
include the label for the action. No strong opinion though.

-- 
Configure bugmail: http://netbeans.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


[Bug 228409] New: export package as spi

mkleint 04/09/2013

[Bug 228409] export package as spi

mkleint 04/09/2013

[Bug 228409] export package as spi

mkleint 04/09/2013

[Bug 228409] export package as spi

mkozeny 04/10/2013

[Bug 228409] export package as spi

mkozeny 04/10/2013

[Bug 228409] export package as spi

mkozeny 04/10/2013

[Bug 228409] export package as spi

mkleint 04/10/2013

[Bug 228409] export package as spi

tzezula 04/10/2013

[Bug 228409] export package as spi

mkleint 04/11/2013

[Bug 228409] export package as spi

mkozeny 04/17/2013

[Bug 228409] export package as spi

mkozeny 04/17/2013

[Bug 228409] export package as spi

mkozeny 04/18/2013

[Bug 228409] export package as spi

mkleint 04/18/2013

[Bug 228409] export package as spi

mkozeny 04/24/2013

[Bug 228409] export package as spi

quality 04/28/2013

Project Features

About this Project

APIsupport was started in November 2009, is owned by Antonin Nebuzelsky, and has 43 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20140418.2d69abc). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close