This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 96520 - "Next" action in CVS Diff window skips blocks of changes
Summary: "Next" action in CVS Diff window skips blocks of changes
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: 6.x
Hardware: PC Windows XP
: P2 blocker (vote)
Assignee: diff-issues@utilities
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2007-02-25 12:59 UTC by kirillkh
Modified: 2007-03-19 17:05 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
tooltip (2.21 KB, application/octet-stream)
2007-02-26 11:37 UTC, Josef Pavlicek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kirillkh 2007-02-25 12:59:21 UTC
Sometimes (not very often), when I open a Diff window for source file under CVS
control and press "Next" (down arrow) button, it skips one or more blocks of
changes in the beginning of the file. As a result, one can overlook the changes
that were made to the file and inadvertently commit them. This actually happened
to me a couple of times.

This is an old bug - at least as old as 6.0 development, but I seem to recall it
also happened to me on 5.5 (haven't used it since October).

I don't know, what triggers the bug. Most of the time it doesn't happen; but
when it does, it is reproducible on the same file, when you don't make any
additional changes to it.

1. change a file under the CVS control
2. diff it
3. press the down arrow button
4. scroll up to see that some blocks of changes have been skipped
Comment 1 Maros Sandor 2007-02-26 09:47:32 UTC
I guess that you ran into a nice feature but did not appreciate it :-) We will
need to re-evaluate the feature with UI experts here. Let me explain: currently,
the Next button does not navigate to the next ordinal difference but to the next
off-screen difference. Imagine you have 3 differences, at the start, in the
middle and at the end. If you hand-scroll the document to the middle, the Next
button will navigate you to the end of the document.
Comment 2 Josef Pavlicek 2007-02-26 11:35:50 UTC
Instead of that (what write Maros) the button has tooltip. This is not UI bug.
But I can promises we will have a better DIFF viewer, I am sure, you will not
have these problem in the future. There is the new DIFF UI Spec
http://ui.netbeans.org/docs/ui/DiffSpecification/DIFFSpecification.html

Thank  you for your submission
Josef Pavlicek 
xDesign team 
Comment 3 Josef Pavlicek 2007-02-26 11:37:19 UTC
Created attachment 38901 [details]
tooltip
Comment 4 kirillkh 2007-02-26 12:16:29 UTC
Re josefpavlicek: this is a very nice spec, something along the lines I have
been awaiting for a long time. When is it going to be implemented?

Re msandor:
1. I understand what you say and, indeed, I observed such behavior
2. However, in my scenario I don't scroll anywhere - I simply diff the files and
press the "down" button. If my understanding is correct, in this case, no
changes should be skipped, but sometimes they are. I don't currently have a test
case at hand to confirm this, but the issue happened to me yesterday, and I'm
pretty confident it exists.
3. Independently of existence of the bug, I think that this behavior is
dangerous and needs fixing. I would guess that "navigate to the off-screen
difference" behavior was implemented, because there was no other way to jump
directly to the difference that goes below the current view position without the
need to go through all the preceding differences first. I would like to suggest
another, hopefully better, solution to this: to have a "diff stripe" in the Diff
view. Then, you could restore the old behavior of the "Next" button (jumping
strictly to the next difference, without taking into account the scroll
position), because the user would be able to navigate to the next off-screen
difference by clicking on it in the stripe. Maybe it would be a good and not too
time consuming idea to implement this as an intermediate measure, before the
full-blown Diff remake is finished (unless it is going to be finished really
soon - that is, for 6.0).
Comment 5 Josef Pavlicek 2007-02-26 15:19:12 UTC
Hi,
It would be finished until M8.
Josef
Comment 6 kirillkh 2007-02-26 15:22:55 UTC
Neat! Looking forward to get my hands on it :)
Comment 7 Maros Sandor 2007-03-19 17:05:47 UTC
Currently, when you use navigation buttons you never skip any changes.