This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 95765 - Hide o.n.m.editor.PopupActions and PopupInitializer
Summary: Hide o.n.m.editor.PopupActions and PopupInitializer
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@editor
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2007-02-16 05:08 UTC by Vitezslav Stejskal
Modified: 2007-11-05 13:44 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
The diff showing the change (1.87 KB, text/plain)
2007-02-16 05:09 UTC, Vitezslav Stejskal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vitezslav Stejskal 2007-02-16 05:08:46 UTC
The o.n.m.editor.PopupActions and PopupInitializer should have never been made
publically accessible. They are part of editor's internal implementation that
provides support for registering editor popup menu action in MimeLookup. The
'Popup' folder and MimeLookup is the public contract, which is used by all
modules. There is no reason for anybody to call or use PopupActions and
PopupInitializer classes directly, hence there is no reason for having them in a
public package.
Comment 1 Vitezslav Stejskal 2007-02-16 05:09:35 UTC
Created attachment 38594 [details]
The diff showing the change
Comment 2 Vitezslav Stejskal 2007-02-16 05:15:00 UTC
I would like to move these two classes away from the public package. None of the
modules in standard Netbeans distribution uses them and as I believe no one else
uses them either. The attached diff shows the change. If there are no objections
I'll write a note to apichanges.xml and commit the change.

Thanks for the review.
Comment 3 Vitezslav Stejskal 2007-02-19 02:03:55 UTC
Integrated.

Checking in src/org/netbeans/modules/editor/NbEditorKit.java;
/cvs/editor/src/org/netbeans/modules/editor/NbEditorKit.java,v  <-- 
NbEditorKit.java
new revision: 1.104; previous revision: 1.103
done
Removing src/org/netbeans/modules/editor/PopupActions.java;
/cvs/editor/src/org/netbeans/modules/editor/PopupActions.java,v  <-- 
PopupActions.java
new revision: delete; previous revision: 1.4
done
Removing src/org/netbeans/modules/editor/PopupInitializer.java;
/cvs/editor/src/org/netbeans/modules/editor/PopupInitializer.java,v  <-- 
PopupInitializer.java
new revision: delete; previous revision: 1.3
done
RCS file: /cvs/editor/src/org/netbeans/modules/editor/impl/PopupActions.java,v
done
Checking in src/org/netbeans/modules/editor/impl/PopupActions.java;
/cvs/editor/src/org/netbeans/modules/editor/impl/PopupActions.java,v  <-- 
PopupActions.java
initial revision: 1.1
done
RCS file: /cvs/editor/src/org/netbeans/modules/editor/impl/PopupInitializer.java,v
done
Checking in src/org/netbeans/modules/editor/impl/PopupInitializer.java;
/cvs/editor/src/org/netbeans/modules/editor/impl/PopupInitializer.java,v  <-- 
PopupInitializer.java
initial revision: 1.1
done
Checking in apichanges.xml;
/cvs/editor/apichanges.xml,v  <--  apichanges.xml
new revision: 1.7; previous revision: 1.6
done
Checking in nbproject/project.properties;
/cvs/editor/nbproject/project.properties,v  <--  project.properties
new revision: 1.29; previous revision: 1.28
done
Checking in
src/META-INF/services/org.netbeans.spi.editor.mimelookup.Class2LayerFolder;
/cvs/editor/src/META-INF/services/org.netbeans.spi.editor.mimelookup.Class2LayerFolder,v
 <--  org.netbeans.spi.editor.mimelookup.Class2LayerFolder
new revision: 1.5; previous revision: 1.4
done
Comment 4 Vitezslav Stejskal 2007-02-19 05:16:10 UTC
Done