This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 94655 - I18N - Bundle-JSF.properties needs to be in l10n kits
Summary: I18N - Bundle-JSF.properties needs to be in l10n kits
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 5.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: Ch Nguyen
URL:
Keywords: I18N
: 109380 (view as bug list)
Depends on: 105741
Blocks:
  Show dependency tree
 
Reported: 2007-02-06 15:53 UTC by bugbridge
Modified: 2007-09-28 21:17 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bugbridge 2007-02-06 15:53:17 UTC
Original status: 3-Accepted; Suggested Status: NEW

Original Target Release: shortfin_dev; Suggested Target Milestone : 5.5


Original submitter: kfrank

Description:
This was discussed in separate mails by dev and RE some months ago - to
have the Bundle-JSF.properties, get into regular kits instead of l10n
needing to get them from product.
I think there were some proposed or possible solutions to this so just
filing it here to get on the radar for mako.

Description (Entry 2):
Based on feedback from l10n team, this is being changed to a bug
since it does impact their work needing to get these kind of files
separately.

Based on earlier mail with Ashvini, there did seem to be a solution
to this - ie, the l10n kits having the Bundle-JSF.properties files
and any other post build generated localizable files like them
that might happen in future.

Evaluation:
I've reassigned the ownership.  We need sometime to figure out what to do about
this issue.

Evaluation (Entry 2):
Still investigating this.  For some reason, these files although exist by the
time the l10n-kit target is called,  they won't be picked up even when listed in
the l10n.list.

Evaluation (Entry 3):
This has no user impact.  The change request is to improve the internal l10n-kit
ant target so that it'll handle the special files as well.  Since the l10n team
is OK with manually extracting the special files just like previous release and
this issue is no longer urgent for this FCS release,  I've discussed with Ken to
lower this to P3 and he agreed.
Comment 1 Ken Frank 2007-03-29 03:49:24 UTC
now that vwp is in opensource and we are aligning with other modules,
this is being raised back to p2; it does need to be fixed for nb6 timeframe.

Having l10n manually extract was only meant as short term workaround;
l10n team are our customers of l10n kits and we need to make sure
like for all other modules and components, that things are in kits.

ken.frank@sun.com
Comment 2 Ch Nguyen 2007-04-30 16:42:09 UTC
Definitely not for M9.  I also need to know how the l10nkit is build in the NB
structure.  Do you have any pointer?
Comment 3 Ken Frank 2007-05-21 16:59:28 UTC
nb-re is handling this for nb6, as to how kits are/will be built.

ken.frank@sun.com
Comment 4 rbalada 2007-06-28 18:41:18 UTC
For any module requiring generated stuff to be in L10N kit use "antcall custom-target" syntax in local l10n.list override.

Sample local l10n.list override can be found at
http://www.netbeans.org/source/browse/visualweb/webui/designtime/l10n.list?view=markup

Documentation about syntax and use-cases for local l10n.list override can be found on wiki page
http://wiki.netbeans.org/wiki/view/NetBeans6.0L10NListHOWTO

From Build Engineering point of view we reached the point where Development team takes over responsibility for L10N kit
accuracy. There's infrastructure and documentation how configure your module for L10N kit build to make it accurate. Do
not hesitate to file an issue against nbbuild module in case something does not work for you.
Comment 5 Ken Frank 2007-07-02 05:42:08 UTC
Rudolf.

I see some Bundle-JSF.properties in the new test, l10n kits inside the visualweb.tar

Chau, see
deadlock.netbeans.org/hudson/job/l10nkit

A quick look at Bundle-JSF.propeties in product vs kit showed most were in kit (though i don't know if path was
correct or if the files in the kit match the ones in the product) and one file was not in kit - but as Rudolf mentions,
thats up to dev team to make sure the additional
l10n.list files are created, populated and that the kits are accurate.

I'm emphasizing this because adding the Bundle-JSF.propeties to the kit is a special and new step, and sugggest
dev team make sure the files in the kit do match the files in the product of that date.


Or it might be that some global pattern that could be in RE global l10n.list needs to be added to that file
if its a common pattern vs needing to be in specific module l10n.list.



ken.frank@sun.com
Comment 6 Ch Nguyen 2007-07-02 23:57:49 UTC
Ken, which one that is not in the kit?
Comment 7 Ch Nguyen 2007-07-16 19:58:14 UTC
*** Issue 109380 has been marked as a duplicate of this issue. ***
Comment 8 Ch Nguyen 2007-07-26 23:31:44 UTC
Fix the generate target in xhtml so that it'll include the Bundle-JSF.properties file in the l10n-kit now.
Checking in build.xml;
/cvs/visualweb/xhtml/build.xml,v  <--  build.xml
new revision: 1.4; previous revision: 1.3
done
Checking in l10n.list;
/cvs/visualweb/xhtml/l10n.list,v  <--  l10n.list
new revision: 1.2; previous revision: 1.1
done

Moving on to the next module visualweb/dataprovider/designtime.  The 'generate' ant target works fine in this module. 
However when setting up the l10n.list to do:
ant generate
read global

It doesn't work.  I also found that the l10n-kit's visualweb.tar can't be extracted.  I got "directory checksum error".
 This is happening in my local build as well as the download l10n-kit from deadlock.netbeans.org/hudson/job/l10nkit.

So I've a new bug on that issue 111180. 
Comment 9 Ch Nguyen 2007-07-30 16:35:30 UTC
As pointed out in issue 111180, I was not using the gnu tar command to extract the content of the l10n-kit for
verification. After I was able to extract successfully, it looks to me that all the needed Bundle-JSF.properties are now
in the kit. 
Comment 10 Ken Frank 2007-09-28 21:17:02 UTC
verified.