This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
(See the attached picture). There are several inconsistencies in the editor toolbar which may confuse users. The "find next/previous occurence" buttons are in a different order with respect to "next/previous bookmark" and "next/previous matching word". Also, the toggle highlight search is the last in its tab while "toggle bookmark" is the first. Furthermore, "toggle bookmark" and "toggle highligh search" do not indicate their state (= are never visually "pushed").
Created attachment 38048 [details] Current toolbar in NB5.5 and promoH
Yeah, still the same in a dev build. What would be the suggested ordering please, if I may ask? Thank you.
The suggested ordering is in the specification attached: http://ui.netbeans.org/docs/ui/editor_toolbar_reordering/#specification . But could you please wait with the implementation until the spec. will go through a review at nb-usability@sun.com? It has been sent out today.
I see, cool! Please, let us know when the spec is final. Thanks.
Created attachment 38631 [details] New icons
Created attachment 38632 [details] New icons
Partially done. The buttons positions and icons updated. We still need to implement the toggle buttons. Checking in bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/previous_bookmark.png; /cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/previous_bookmark.png,v <-- previous_bookmark.png new revision: 1.3; previous revision: 1.2 done Checking in bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/next_bookmark.png; /cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/next_bookmark.png,v <-- next_bookmark.png new revision: 1.3; previous revision: 1.2 done Checking in bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/layer.xml; /cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/layer.xml,v <-- layer.xml new revision: 1.8; previous revision: 1.7 done Checking in src/org/netbeans/modules/editor/resources/layer.xml; /cvs/editor/src/org/netbeans/modules/editor/resources/layer.xml,v <-- layer.xml new revision: 1.87; previous revision: 1.86 done
Done now. The two toggle-type actions show their state visually. They look like a pushed button when the feature is on (ie. search highlighting, a bookmark on the line with the caret). I am not sure if this visual appearance is ok though, so if anybody has any comments we can negotiate a change. Checking in src/org/netbeans/modules/editor/resources/layer.xml; /cvs/editor/src/org/netbeans/modules/editor/resources/layer.xml,v <-- layer.xml new revision: 1.88; previous revision: 1.87 done Checking in bookmarks/src/org/netbeans/lib/editor/bookmarks/BookmarksApiPackageAccessor.java; /cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/BookmarksApiPackageAccessor.java,v <-- BookmarksApiPackageAccessor.java new revision: 1.3; previous revision: 1.2 done Checking in apichanges.xml; /cvs/editor/apichanges.xml,v <-- apichanges.xml new revision: 1.9; previous revision: 1.8 done Checking in bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/ToggleBookmarkAction.java; /cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/ToggleBookmarkAction.java,v <-- ToggleBookmarkAction.java new revision: 1.4; previous revision: 1.3 done Checking in bookmarks/nbproject/project.xml; /cvs/editor/bookmarks/nbproject/project.xml,v <-- project.xml new revision: 1.7; previous revision: 1.6 done Checking in libsrc/org/netbeans/editor/ActionFactory.java; /cvs/editor/libsrc/org/netbeans/editor/ActionFactory.java,v <-- ActionFactory.java new revision: 1.81; previous revision: 1.80 done Checking in libsrc/org/netbeans/editor/Utilities.java; /cvs/editor/libsrc/org/netbeans/editor/Utilities.java,v <-- Utilities.java new revision: 1.85; previous revision: 1.84 done Checking in bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/layer.xml; /cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/resources/layer.xml,v <-- layer.xml new revision: 1.9; previous revision: 1.8 done RCS file: /cvs/editor/src/org/netbeans/modules/editor/impl/ToolbarActionsProvider.java,v done Checking in src/org/netbeans/modules/editor/impl/ToolbarActionsProvider.java; /cvs/editor/src/org/netbeans/modules/editor/impl/ToolbarActionsProvider.java,v <-- ToolbarActionsProvider.java initial revision: 1.1 done Checking in src/org/netbeans/modules/editor/impl/ActionsList.java; /cvs/editor/src/org/netbeans/modules/editor/impl/ActionsList.java,v <-- ActionsList.java new revision: 1.3; previous revision: 1.2 done Checking in src/org/netbeans/modules/editor/impl/PopupMenuActionsProvider.java; /cvs/editor/src/org/netbeans/modules/editor/impl/PopupMenuActionsProvider.java,v <-- PopupMenuActionsProvider.java new revision: 1.2; previous revision: 1.1 done Checking in src/org/netbeans/modules/editor/NbEditorKit.java; /cvs/editor/src/org/netbeans/modules/editor/NbEditorKit.java,v <-- NbEditorKit.java new revision: 1.106; previous revision: 1.105 done Checking in src/org/netbeans/modules/editor/NbEditorToolBar.java; /cvs/editor/src/org/netbeans/modules/editor/NbEditorToolBar.java,v <-- NbEditorToolBar.java new revision: 1.31; previous revision: 1.30 done Checking in nbproject/project.properties; /cvs/editor/nbproject/project.properties,v <-- project.properties new revision: 1.32; previous revision: 1.31 done Checking in src/META-INF/services/org.netbeans.spi.editor.mimelookup.Class2LayerFolder; /cvs/editor/src/META-INF/services/org.netbeans.spi.editor.mimelookup.Class2LayerFolder,v <-- org.netbeans.spi.editor.mimelookup.Class2LayerFolder new revision: 1.8; previous revision: 1.7 done Checking in bookmarks/src/org/netbeans/lib/editor/bookmarks/api/BookmarkList.java; /cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/api/BookmarkList.java,v <-- BookmarkList.java new revision: 1.5; previous revision: 1.4 done Checking in bookmarks/src/org/netbeans/modules/editor/bookmarks/WrapperBookmarkAction.java; /cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/WrapperBookmarkAction.java,v <-- WrapperBookmarkAction.java new revision: 1.6; previous revision: 1.5 done