This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 92075 - Show the exception dialog for Development builds
Summary: Show the exception dialog for Development builds
Status: VERIFIED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Logger (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: API_REVIEW_FAST, REGRESSION, UI
Depends on:
Blocks:
 
Reported: 2007-01-09 09:12 UTC by Marian Mirilovic
Modified: 2007-02-15 08:55 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
This should allow the UI Gestures Collector to contribute the "report..." button seamlessly (15.49 KB, patch)
2007-01-11 20:06 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Mirilovic 2007-01-09 09:12:01 UTC
NetBeans IDE Dev (Build 200701081900)
1.6.0; Java HotSpot(TM) Client VM 1.6.0-b105
Linux version 2.6.12-10-686 running on i386

Current implementation of UI Gesture Collector is catching exceptions / errors
and the red icon is shown in that case in bottom-right corner. This is very nice
and very good solution for FCS build, but not for the Development ones.

The second possible solution is to send exception into database, but until we
have control over this DB and the exception is processed by somebody into IZ we
need to show exception dialogs to user by default.
Comment 1 Jaroslav Tulach 2007-01-10 12:44:49 UTC
Not only that an icon is shown, also a dialog is opened that allows to submit 
the bug to the server and also inspect the logged data. Where is the problem?
Comment 2 Marian Mirilovic 2007-01-10 12:50:01 UTC
1. in the private email you said this is bug
2. yes there is a dialog asking to send report (UI Gestures + Error/Exception)
so this is a little bit different
3. showing the Exception dialog during for development versions of the IDE was
decided long time ago as a solution to ask users to report a possible problems
into the IZ - with your module, they are not sending reports into IZ !
4. if the user push the "Never Again" button - he/she will never again see the
modal exception dialog asking for reporting the problem 
Comment 3 Jesse Glick 2007-01-10 14:03:42 UTC
Please make sure that

  -J-Dnetbeans.exception.report.min.level=999999

continues to work to suppress the dialog box (showing only the error icon), for
those of us users of dev builds who hate the dialog and never want to see it and
know how to use a text editor to look at the log file. :-)
Comment 4 pzajac 2007-01-11 08:26:01 UTC
 I agree that we don't need icon in right corner in dev build.  Many developers
who are not  testers use milestone build. We can suppose e that they rather
prefere icon in right corner than dialog with exception stacktrace which is
opened every time.   We can expect that no tester will use the milestone build
after its release. Marian can you explain me why do you think that it's really
milestone showstopper a so important bug? 
Comment 5 Jaroslav Tulach 2007-01-11 10:26:54 UTC
I cannot change the UI for M6:
1) it needs a UI review which needs few days
2) it needs fast track api review and which usually takes a week
I'll fix it for M7. 

Now the question is what to do for M6? I can either leave it as it is, or I 
can return back the original behaviour - e.g. do not offer upload on 
exception. The other option is to delay M6 for a week.
Comment 6 Lukas Hasik 2007-01-11 10:51:26 UTC
to Zajo:
The question is - for what are the Milestones builds used? 
IMO, we want as much issue reports about the milestones as possible. The
milestones should be more stable then daily builds therefore more users will use
them. The reports from users are valuable. Let them report the problems. When
the exceptions are somehow hidden from the milestones builds than we cannot
improve the quality of the product in the right way. When exception dialog
appeared then they knew there is something wrong. 
Comment 7 Jaroslav Tulach 2007-01-11 10:56:33 UTC
#92075: Temporarily disabling the exception report via UI Gestures collector 
per agreement with Marian

I guess this is no longer M6-stopper, although it needs to be fixed.

/shared/data/ccvs/repository/logger/uihandler/src/org/netbeans/modules/uihandler/UIHandler.java,v  
<--  UIHandler.java
new revision: 1.11; previous revision: 1.10
done
Checking in Installer.java;
/shared/data/ccvs/repository/logger/uihandler/src/org/netbeans/modules/uihandler/Installer.java,v  
<--  Installer.java
new revision: 1.40; previous revision: 1.39
Comment 8 Marian Mirilovic 2007-01-11 11:21:14 UTC
Agreed with this temporary solution (thanks Jarda & Tonda). 

Jarda will change the behavior of the original Exceptions dialog(add Submit
button) after UI/API reviews a week after M6 announcement.

Thanks for your comments and help.
Comment 9 pzajac 2007-01-11 11:39:46 UTC
I also agree with the solution. Marian thanks for explanation. I am for to show
dialog during milestone testing. But I am not really sure if it is good to show
the dialog every time after milestone release. I am for example for to have
checkbox in exception dialog - "Leave on background". If the checkbox is
selected only icon in right corner will be shown. 
Comment 10 Lukas Hasik 2007-01-11 15:14:44 UTC
it's great idea to have an option to switch the exception dialog on/off. 
It would help for testing of the IDE. Testers could switch the option on. Users
that are not interested in exception could switch it off.
The property should be in Options, and a check box for easy switch off on the
exception dialog.
Comment 11 Jesse Glick 2007-01-11 16:05:35 UTC
+1 on having a checkbox in the exception dialog labelled e.g. "Open Dialog upon
Exception", checked by default. People using the IDE for normal work (or who are
testing but using the log file or console directly) would simply uncheck it as
soon as they got sufficiently annoyed by the dialog popping up. No need to give
the IDE a cryptic command-line option to turn off the dialog, and if you want
you can even turn it on in a release build. Nice idea!

No need to put anything in the Options dialog, I think. Presenting a
configuration option in context is always better. If you have the dialog turned
off and want to turn it back on, just wait until the next time the error icon
appears, click it to show the dialog, and check the check box.
Comment 12 Lukas Hasik 2007-01-11 16:16:50 UTC
+1 for Jesse's last comment. 
Comment 13 Jaroslav Tulach 2007-01-11 16:17:08 UTC
IZ is not the best place for discussions. I'll announce a UI review on nbui, 
let's keep ideas and opinions for a discussion there.
Comment 14 Jaroslav Tulach 2007-01-11 20:01:01 UTC
I guess I will need an API between core and logger/uihandler. I propose to 
make it friend contract. Btw. It is really innovative. It is surprising where 
one can find various useful objects to perform instanceof on ;-)
Comment 15 Jaroslav Tulach 2007-01-11 20:06:51 UTC
Created attachment 37288 [details]
This should allow the UI Gestures Collector to contribute the "report..." button seamlessly
Comment 16 Marian Mirilovic 2007-01-12 08:40:55 UTC
verified in NB Dev (200701111900) - the Unexpected Exception dialog works as it
used to - thanks.
Comment 17 Jaroslav Tulach 2007-01-17 11:11:27 UTC
Thanks for review, I'll integrate the "Report Exception" button tomorrow.
Comment 18 Jaroslav Tulach 2007-01-18 13:01:29 UTC
"#92075: Showing exception dialog with 'Report Problem' button"
Checking in core/arch/arch-core.xml;
/shared/data/ccvs/repository/core/arch/arch-core.xml,v  <--  arch-core.xml
new revision: 1.16; previous revision: 1.15
done
Checking in core/nbproject/project.properties;
/shared/data/ccvs/repository/core/nbproject/project.properties,v  <--  
project.properties
new revision: 1.30; previous revision: 1.29
done
Checking in core/src/org/netbeans/core/NotifyExcPanel.java;
/shared/data/ccvs/repository/core/src/org/netbeans/core/NotifyExcPanel.java,v  
<--  NotifyExcPanel.java
new revision: 1.4; previous revision: 1.3
done
Checking in core/test/unit/src/org/netbeans/core/NotifyExcPanelTest.java;
/shared/data/ccvs/repository/core/test/unit/src/org/netbeans/core/NotifyExcPanelTest.java,v  
<--  NotifyExcPanelTest.java
new revision: 1.2; previous revision: 1.1
done
Checking in logger/uihandler/arch.xml;
/shared/data/ccvs/repository/logger/uihandler/arch.xml,v  <--  arch.xml
new revision: 1.8; previous revision: 1.7
done
Checking in logger/uihandler/manifest.mf;
/shared/data/ccvs/repository/logger/uihandler/manifest.mf,v  <--  manifest.mf
new revision: 1.15; previous revision: 1.14
done
Checking in 
logger/uihandler/src/org/netbeans/modules/uihandler/Bundle.properties;
/shared/data/ccvs/repository/logger/uihandler/src/org/netbeans/modules/uihandler/Bundle.properties,v  
<--  Bundle.properties
new revision: 1.21; previous revision: 1.20
done
Checking in 
logger/uihandler/src/org/netbeans/modules/uihandler/Installer.java;
/shared/data/ccvs/repository/logger/uihandler/src/org/netbeans/modules/uihandler/Installer.java,v  
<--  Installer.java
new revision: 1.42; previous revision: 1.41
done
Checking in 
logger/uihandler/src/org/netbeans/modules/uihandler/UIHandler.java;
/shared/data/ccvs/repository/logger/uihandler/src/org/netbeans/modules/uihandler/UIHandler.java,v  
<--  UIHandler.java
new revision: 1.12; previous revision: 1.11
done
Checking in 
logger/uihandler/src/org/netbeans/modules/uihandler/api/doc-files/ui.html;
/shared/data/ccvs/repository/logger/uihandler/src/org/netbeans/modules/uihandler/api/doc-files/ui.html,v  
<--  ui.html
new revision: 1.5; previous revision: 1.4
done
Checking in 
logger/uihandler/test/unit/src/org/netbeans/modules/uihandler/BugTriggersTest.java;
/shared/data/ccvs/repository/logger/uihandler/test/unit/src/org/netbeans/modules/uihandler/BugTriggersTest.java,v  
<--  BugTriggersTest.java
new revision: 1.8; previous revision: 1.7
done
Checking in logger/www/welcome/error.html;
/shared/data/ccvs/repository/logger/www/welcome/error.html,v  <--  error.html
new revision: 1.6; previous revision: 1.5
done
Comment 19 Marian Mirilovic 2007-02-15 08:55:21 UTC
verified in NB Dev(200702141900)