This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
reproduicible with 061213 steps: 1. extract and open project from atachment 2. open 'p_deployment|d_deployment' diagram by double click diagram is marked as dirty
Created attachment 36874 [details] project
Thanks for the testcase, it helped. There's logic in ADDrawingAreaControl to verify diagram right after loading to get rid of invalid nodes, edges etc. In this particular case, the diagram contains three linked comments, two of them are linked to comment while Comment edge verification logic expects comment to be linked to a non-comment element, which is flawed by itself. So the edges deemed invalid were deleted after loading the diagram without user's knowledge, that's why the diagram was marked as modified. In any case, I tend to think we should not alter diagram under the cover while loading, just display it in whatever the state user saved. Removed postLoadVerification()
verified in all-nbms-griffin-070212
Fixing this bugs causes issue 91395. The logic that was commented out is very important. I am uncommenting the code.
After testing this, I am not able to see the described behavior. I believe that the new save logic fixed this issue.
verified again in build 070222_1 that this issue is no longer reproducible.
The attempted fix was reverted back on 2/21, so the issue comes back. Apparently there's a mistake in the comment "Fixing this bugs causes issue 91395", this is 91395. This is the direct cause of issue 101695, raise it to p1 for possible data loss. Even though we detect inconsistency in persisted model data given that verification logic is correct (which is not the case in this particular issue), we should notify user instead of modifying diagrams behind the scene.
It's quite complex issue, from one point diagram should be cleared from deleted elements, updated with renamed etc elements but sometimes it looks strange if nothing was changed by user but verification change something
Two parts: 1. Fixed the comment validation logic to fix the issue of link comment elements in the attached project. 2. Whenever there is a change in the model and the diagram is out of sync, we validate the diagram to remove deleted elements/relationships. It was decided by QE and Dev teams that we inform the user when there is such a change in the diagram (to make the model and diagram to be in sync).
verified in netbeans-6.0-nightly-200705250000-full