This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 91323 - JSP/EL lexer tests do not run in nightly test runs
Summary: JSP/EL lexer tests do not run in nightly test runs
Status: CLOSED FIXED
Alias: None
Product: qa
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: ehucka
URL: http://beetle.czech/automatedtests/xt...
Keywords: TEST
Depends on:
Blocks:
 
Reported: 2006-12-20 12:40 UTC by Petr Jiricka
Modified: 2011-02-17 09:36 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2006-12-20 12:40:52 UTC
The following test runs do not run correcly in the nightly test runs:

web/jspsyntax/lexer
web/el/lexer

They pass fine when run locally. Problem is in the infrastructure.
Comment 1 ehucka 2006-12-20 13:31:25 UTC
There is probably some cycle in web/el/lexer configuration:

/space/test4u2/cvswork/nb_all/web/el/lexer/test/build-unit.xml:25: The following
error occurred while executing this line:
/space/test4u2/cvswork/nb_all/nbbuild/templates/xtest.xml:55: The following
error occurred while executing this line:
/space/test4u2/distributions/netbeans-trunk/lib/module_harness.xml:361: The
following error occurred while executing this line:
/space/test4u2/cvswork/nb_all/web/el/lexer/test/build-unit.xml:25: The following
error occurred while executing this line:
/space/test4u2/cvswork/nb_all/nbbuild/templates/xtest.xml:55: The following
error occurred while executing this line:
/space/test4u2/distributions/netbeans-trunk/lib/module_harness.xml:361: The
following error occurred while executing this line:
/space/test4u2/cvswork/nb_all/web/el/lexer/test/build-unit.xml:25: The following
error occurred while executing this line:
/space/test4u2/cvswork/nb_all/nbbuild/templates/xtest.xml:55: The following
error occurred while executing this line:
/space/test4u2/distributions/netbeans-trunk/lib/module_harness.xml:361: The
following error occurred while executing this line:
/space/test4u2/cvswork/nb_all/web/el/lexer/test/build-unit.xml:25: The following
error occurred while executing this line:
java.lang.OutOfMemoryError: Java heap space

Jirko, could you look at it?
Comment 2 ehucka 2006-12-20 13:45:04 UTC
The issue of web/jspsyntax/lexer tests was fixed yesterday. 
The cycle in web/el/lexer tests blocks other unit tests for about 590 minutes.
It should be fixed or removed from master-config.
Comment 3 Jiri Skrivanek 2006-12-20 13:59:24 UTC
Build script fixed. To prevent the cycle thedir attribute has to be used when
calling buildtests to override basedir property.

/cvs/web/el/lexer/test/build-unit.xml,v  <--  build-unit.xml
new revision: 1.3; previous revision: 1.2
Comment 4 ehucka 2006-12-20 15:01:43 UTC
I tried to run the tests on test4u and they passed.
Comment 5 Marian Mirilovic 2006-12-21 13:25:20 UTC
Jirka, Petr J., Eman,
how is it possible that these tests were running fine locally but it were not
running on test4u ?
Comment 6 ehucka 2006-12-21 14:17:11 UTC
1. Developers usually work on whole cvs repository. It solves all tests/projects
dependecies by 'brutal force'.
Because of there is not any way how to obtain cvs entries from code-bases except
to checkout whole cvs repository Test4u can either checkout whole repository for
each tests or let users to select what will be checked out. By performance
reasons there is implemented the second way now.

2. Test4u uses xtest instance for execution of tests. I think starting of tests
by <module>/test/build.xml can be a bit different than by xtest instance.
Comment 7 Jiri Skrivanek 2006-12-21 14:23:42 UTC
The difference appears when you run tests using XTest instance. When you run
tests from web/el/lexer/test/ directory, even the following call in
build-unit.xml is fine:

<ant inheritall="false" antfile="../../../../lexer/test/build.xml"
target="buildtests"/>

But when you run test from instance, it calls lexer/test/build.xml#buildtests
but property basedir still points to web/el/lexer/test and buildtests target is
called in a loop. One have to use the following call because it sets basedir to
a new value:

<ant dir="../../../../lexer/test" target="buildtests" inheritall="false"/>

Comment 8 Marian Mirilovic 2006-12-21 15:24:24 UTC
Eman, Jirka,
thanks for explanation, now I see. 
It looks like when we start to use binary test distribution it would be almost
the same as when one runs the tests locally, Am I right?

Comment 9 ehucka 2006-12-21 16:41:31 UTC
I do not know, probably the same as if one starts own binary distribution
locally. :)
Comment 10 pzajac 2007-01-02 12:58:03 UTC
>It looks like when we start to use binary test distribution it would be almost
>the same as when one runs the tests locally, Am I right?

It will work in bintestdist, btw. Test are compiled by using nbbuild/ harness.    

Target "unit-compiler" is newer called in test distribution. 

path of <import file="./../../../...xtest-unit..xml"/> is converted to  path in
binary test distribution. The hack is covered in test: 
nbbuild/test/unit/src/org/netbeans/nbbuild/ConvertImportTest.java