This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 89119 - Various suspicious patterns in xml/wsdl/api
Summary: Various suspicious patterns in xml/wsdl/api
Status: RESOLVED WONTFIX
Alias: None
Product: xml
Classification: Unclassified
Component: WSDL Model (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Shivanand Kini
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-10 14:56 UTC by _ rkubacki
Modified: 2016-07-07 09:56 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2006-11-10 14:56:27 UTC
Many of these are mentioned in 
http://www.netbeans.org/community/guidelines/code-conventions.html. All these
things can also be discovered with PMD plugin (pmd.sf.net)

Catching of Throwable - it is too general and cover probably much more than is
originaly expected.

Suspicious use of String.toUpperCase()

Careful with string.toUpperCase() and string.toLowerCase(). In Turkish locale, I
 and i are not case variants, they are different letters. Unless you know what
you are doing, use string.toUpperCase(Locale.US) or string.toLowerCase(Locale.US).

Statically held ResourceBundle in SOAPComponentValidator - once loaded it does
not allow to free memory when it is no longer need.
Comment 1 Ritesh Adval 2007-02-28 00:13:24 UTC
Statically held ResourceBundle in SOAPComponentValidator is used because this
validator is called frequently when user validates wsdl, so we do not want to
load the bundle again on each invocation.

The other problem is in the model so assign it to Nam.

We need to take locale into account if using toLowerCase/toUpperCase
Comment 2 Nam Nguyen 2007-03-03 09:25:21 UTC
The use of toLowerCase/toUpperCase in reading extension is just attempt for
optimization.  There is default handling if there is no matches.  
Target for 6.0
Comment 3 Martin Balin 2016-07-07 09:56:51 UTC
This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue.

Thanks for your cooperation,
NetBeans IDE 8.2 Release Boss