dev build from Oct 19, JDK 6b98
I turned on diff sidebar in view menu and tried to find some tooltip and switch
to another document. I do not know what is actual cause of problem but EDT
thread waits for some lock and RP thread pool is exhausted with 50 requests that
are all waiting wor some document lock that probably will need something from EDT.
Rather a threading problem than a performance bug. OTOH it might be better to
serialize tasks sent to RP here too.
Created attachment 35415 [details]
I believe this was caused by unnecessary synchronization in DiffSidebar which
was removed yesterday, please verify in later builds. (DiffSideBar.java @ 1.7)
> OTOH it might be better to serialize tasks sent to RP here too.
Not better, I believe this is absolutely necessary, as this code has the
potential to quickly exhaust the RP pool because of e.g. short network outage.
Reopening as P2.
Feel free to close again if you believe that the code won't really block while
running more requests concurrently.
Yes, I plan to create my own RP, it just won't deadlock anymore but may fill up
RP eventually if there are many files open.
Created a dedicated RP for diff sidebars.
new revision: 1.8; previous revision: 1.7
new revision: 1.3; previous revision: 1.2