This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Steps to reproduce: - Create Synchronous sample project. - Open bpel diagram. - Add some property to wsdl (use Navigator). - Add some propertyAlias to wsdl (use Navigator). - Invoke "Add Correlation Set" dialog. - Push "Add" button to add property to correlation set. - Select property and push OK button. - Wait a few seconds and notice that property not added to correlation set.
Created attachment 35190 [details] Stack Overflow stack strace from Add Correlation Set
Ok there are two problems. The first problem is that the Add Property Alias action is resulting in the insertion of a recursive import statement into the WSDL file. Initially SynchronousSample.wsdl looks like this: <definitions xmlns="http://schemas.xmlsoap.org/wsdl/" xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" name="SynchronousSample" targetNamespace="http://localhost/SynchronousSample/SynchronousSample" xmlns:tns="http://localhost/SynchronousSample/SynchronousSample" xmlns:ns="http://xml.netbeans.org/schema/SynchronousSample" xmlns:plink="http://schemas.xmlsoap.org/ws/2004/03/partner-link/" xmlns:bpws="http://schemas.xmlsoap.org/ws/2004/03/business-process/"> <types> After the Add Property Alias action however, it has been modified to import itself. <definitions xmlns="http://schemas.xmlsoap.org/wsdl/" xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" name="SynchronousSample" targetNamespace="http://localhost/SynchronousSample/SynchronousSample" xmlns:tns="http://localhost/SynchronousSample/SynchronousSample" xmlns:ns="http://xml.netbeans.org/schema/SynchronousSample" xmlns:plink="http://schemas.xmlsoap.org/ws/2004/03/partner-link/" xmlns:bpws="http://schemas.xmlsoap.org/ws/2004/03/business-process/"> <import location="SynchronousSample.wsdl" namespace="http://localhost/SynchronousSample/SynchronousSample"/> <types> That is the first bug. The second bug is bug 87107
This is Vitaly fix. He is adding check to make sure the add import logic does no t add current file. http://enterprise.netbeans.org/source/browse/enterprise/bpel/editors/src/org/netbeans/modules/bpel/properties/ImportWsdlRegistrationHelper.java?r1=1.1.2.4&r2=1.1.2.4.2.1 Delta lines: +5 -0 ------------------- --- ImportWsdlRegistrationHelper.java 19 Sep 2006 09:28:35 -0000 1.1.2.4 +++ ImportWsdlRegistrationHelper.java 13 Oct 2006 14:15:30 -0000 1.1.2.4.2.1 @@ -123,6 +123,11 @@ if (importedWsdlModel == null) { return; } + // check if prop alias is in the same wsdl as correlation prop #87102 + if (importedWsdlModel.equals(myWsdlModel)) { + return; + } + Definitions defs = myWsdlModel.getDefinitions(); Collection<Import> imports = defs.getImports(); for (Import elem : imports) {
I reviewed the fix - it looks fine and not risky
vitaly, please check this fix into release55 and adjust ressolution to FIXED.
Fixed
fixed