Please use the Apache issue tracking system for new NetBeans issues ( !!
Bug 86838 - FileRename refactoring can not be undo
FileRename refactoring can not be undo
Product: xml
Classification: Unclassified
Component: Schema Tools
All Windows XP
: P1 (vote)
: 5.x
Assigned To: Nam Nguyen
: 86899 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2006-10-10 08:44 UTC by Nam Nguyen
Modified: 2006-10-12 10:15 UTC (History)
0 users

See Also:
Issue Type: DEFECT

fix (11.40 KB, application/octet-stream)
2006-10-10 16:03 UTC, Nam Nguyen
A simpler and more effective fix. (5.94 KB, patch)
2006-10-10 22:55 UTC, Nam Nguyen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nam Nguyen 2006-10-10 08:44:12 UTC
- Create async SOA sample project.
- In the project explorer, do Refactor>File Rename to rename AsyncSample.xsd to
s/t else
- Right click on the renamed file to see that Refactor > Undo|Redo command are
Comment 1 Nam Nguyen 2006-10-10 09:18:05 UTC
This happen on the second refactorings since the start of the IDE.  The main
cause of this "regression" is from the use of
RefactoringManager.isRunning(UsageSet) to filter out noise events.  Since this
filtering is less restrictive, the noise events from previous UsageSet listner
could reach RefactoringManager causing reset of undo managers.

The fix is to turn off listening on previous refactored models at the start of
processing the next refactoring.

Also, fix in this change is typo causing memory leaks on listeners attached to

Fix checked into release55_dev:

new revision:; previous revision:
new revision:; previous revision:
new revision:; previous revision:
new revision:; previous revision:
new revision:; previous revision:
new revision:; previous revision:
Comment 2 Nam Nguyen 2006-10-10 16:03:31 UTC
Created attachment 35082 [details]
Comment 3 Nam Nguyen 2006-10-10 22:53:41 UTC
A much smaller change is needed.
We only need to make sure we detach the RefactoringManager listener from old
usage set together with clear old undo support before processing the next
Comment 4 Nam Nguyen 2006-10-10 22:55:05 UTC
Created attachment 35097 [details]
A simpler and more effective fix.
Comment 5 Nam Nguyen 2006-10-10 22:55:45 UTC
Fix committed to release55.
Comment 6 Nam Nguyen 2006-10-11 01:23:14 UTC
*** Issue 86899 has been marked as a duplicate of this issue. ***
Comment 7 Ivan Sidorkin 2006-10-12 10:15:27 UTC
verified in 061011_1

By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2014, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo