This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 86555 - Avoid access to env vars through system properties prefixed with "Env-"
Summary: Avoid access to env vars through system properties prefixed with "Env-"
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: _ rkubacki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-05 11:41 UTC by _ rkubacki
Modified: 2008-12-22 17:58 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
javacvs patch (8.81 KB, patch)
2006-12-05 15:56 UTC, _ rkubacki
Details | Diff
subversion patch (3.45 KB, patch)
2006-12-05 15:57 UTC, _ rkubacki
Details | Diff
versioning patch (10.78 KB, patch)
2006-12-05 15:58 UTC, _ rkubacki
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2006-10-05 11:41:33 UTC
o.n.c.startup.Main.readEnvMap copies enviroment vars into System properties
although all places that needs this can use System.getenv() directly (since 1.5
it is undeprecated again).
Comment 1 _ rkubacki 2006-12-05 15:56:57 UTC
Created attachment 36480 [details]
javacvs patch
Comment 2 _ rkubacki 2006-12-05 15:57:19 UTC
Created attachment 36481 [details]
subversion patch
Comment 3 _ rkubacki 2006-12-05 15:58:07 UTC
Created attachment 36482 [details]
versioning patch
Comment 4 _ rkubacki 2006-12-05 15:59:02 UTC
Tomas, Martin: can you review the changes in your modules?
Comment 5 Tomas Stupka 2006-12-05 17:54:51 UTC
i'm fine for the versioning part and thanks for cleaning up
Comment 6 _ rkubacki 2006-12-18 14:24:42 UTC
Checking in
javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ClientRuntime.java;
/shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ClientRuntime.java,v
 <--  ClientRuntime.java
new revision: 1.42; previous revision: 1.41
done
Checking in
javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/CvsModuleConfig.java;
/shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/CvsModuleConfig.java,v
 <--  CvsModuleConfig.java
new revision: 1.4; previous revision: 1.3
done
Checking in
javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/SSHConnection.java;
/shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/SSHConnection.java,v
 <--  SSHConnection.java
new revision: 1.9; previous revision: 1.8
done
Checking in
javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/wizards/RepositoryStep.java;
/shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/wizards/RepositoryStep.java,v
 <--  RepositoryStep.java
new revision: 1.29; previous revision: 1.28
done
Checking in javacvs/libsrc/org/netbeans/lib/cvsclient/command/WrapperUtils.java;
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/command/WrapperUtils.java,v
 <--  WrapperUtils.java
new revision: 1.3; previous revision: 1.2
done
Checking in
javacvs/libsrc/org/netbeans/lib/cvsclient/connection/LocalConnection.java;
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/connection/LocalConnection.java,v
 <-- LocalConnection.java
new revision: 1.8; previous revision: 1.7
done
Checking in javacvs/libsrc/org/netbeans/lib/cvsclient/response/ResponseFactory.java;
/shared/data/ccvs/repository/javacvs/libsrc/org/netbeans/lib/cvsclient/response/ResponseFactory.java,v
 <--  ResponseFactory.java
new revision: 1.30; previous revision: 1.29

Comment 7 _ rkubacki 2006-12-18 14:36:27 UTC
/shared/data/ccvs/repository/subversion/main/src/org/netbeans/modules/subversion/config/SvnConfigFiles.java,v
<--  SvnConfigFiles.java
new revision: 1.42; previous revision: 1.41

/shared/data/ccvs/repository/vcscore/src/org/netbeans/modules/vcscore/settings/GeneralVcsSettings.java,v
 <-- GeneralVcsSettings.java
new revision: 1.22; previous revision: 1.21
done
Checking in vcscore/src/org/netbeans/modules/vcscore/util/VcsUtilities.java;
/shared/data/ccvs/repository/vcscore/src/org/netbeans/modules/vcscore/util/VcsUtilities.java,v
 <--  VcsUtilities.java
new revision: 1.49; previous revision: 1.48
done
Checking in
vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCreateInitialIgnoreList.java;
/shared/data/ccvs/repository/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsCreateInitialIgnoreList.java,v
 <--  CvsCreateInitialIgnoreList.java
new revision: 1.5; previous revision: 1.4
done
Checking in
vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/JavaCvsCommand.java;
/shared/data/ccvs/repository/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/JavaCvsCommand.java,v
 <--  JavaCvsCommand.java
new revision: 1.15; previous revision: 1.14
done
Checking in
vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/passwd/CVSPasswd.java;
/shared/data/ccvs/repository/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/passwd/CVSPasswd.java,v
 <--  CVSPasswd.java
new revision: 1.13; previous revision: 1.12
Comment 8 _ rkubacki 2006-12-20 09:11:11 UTC
Checking in core/arch/arch-core.xml;
/shared/data/ccvs/repository/core/arch/arch-core.xml,v  <--  arch-core.xml
new revision: 1.15; previous revision: 1.14
done
Checking in core/startup/apichanges.xml;
/shared/data/ccvs/repository/core/startup/apichanges.xml,v  <--  apichanges.xml
new revision: 1.3; previous revision: 1.2
done
Checking in core/startup/nbproject/project.properties;
/shared/data/ccvs/repository/core/startup/nbproject/project.properties,v  <-- 
project.properties
new revision: 1.11; previous revision: 1.10
done
Checking in core/startup/src/org/netbeans/core/startup/Main.java;
/shared/data/ccvs/repository/core/startup/src/org/netbeans/core/startup/Main.java,v
 <--  Main.java
new revision: 1.32; previous revision: 1.31