This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 85628 - UI hangs permanently on pressing enter in new Window Component wizard
Summary: UI hangs permanently on pressing enter in new Window Component wizard
Status: VERIFIED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: Code (show other bugs)
Version: 5.x
Hardware: All All
: P1 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-23 10:17 UTC by _ tboudreau
Modified: 2006-09-29 11:09 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Thread dump (33.17 KB, text/plain)
2006-09-23 10:17 UTC, _ tboudreau 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2006-09-23 10:17:43 UTC 
5.5 beta (build 200609040000 w/ apisupport update 2 ver 1.12.22.6.4 impl version
6).  Clean install, first run, only one other project ever created on this
userdir (the Master Detail Nodes Example project I sent to Geertjan yesterday).

Created a new project e:\tmp\gunk
Created a new Window Component from template named "fff"
One other module project open

Finish button remained pressed, files not visibly created, AWT thread blocked
forever.  On restart, I have
fffAction.java
fffTopComponent.java
fffTopComponentSettings.xml

Layer file is still empty.

See attached thread dump.
Comment 1 _ tboudreau 2006-09-23 10:17:59 UTC 
Created attachment 34410 [details]
Thread dump
Comment 2 pzajac 2006-09-25 10:05:20 UTC 
Deadlock between loaders and javacore. Yarda, can you evaluate it?
Comment 3 Jaroslav Tulach 2006-09-25 13:15:22 UTC 
The easiest and most save fix for relese55 would be to modify the 
XMLDataObject to not call to lookup in its constructor. Is that possible?

org.openide.util.lookup.ProxyLookup.lookup(ProxyLookup.java:188)
org.netbeans.modules.xml.core.text.TextEditorSupport.findEditorSuppor
tFactory(TextEditorSupport.java:640)
org.netbeans.modules.xml.core.XMLDataObject.<init>(XMLDataObject.java
:85)
Comment 4 Marek Fukala 2006-09-25 15:09:24 UTC 
AFAIK it is there because of it is possible to have a special XML editor
implementation instead of the default one. One can register an instance of 
EditorSupportFactoryCreater class into the lookup which provides own instance of
TextEditorSupportFactory. OTOH it is an ancient code and I am not aware of any
usage of that. So I think I can remove the code at all.
Comment 5 Marek Fukala 2006-09-25 15:16:20 UTC 
The TextEditorSupport.EditorSupportFactoryCreater class is not in a public
package, but I am not sure whether enterprise pack, creator or other packs don't
use an implementation dependency on the xml/core module to provide their own
editors so it might possible affect them. I'll do the removal of the code and 
send a request for a review to reviewers@netbeans.org so anyone can object if
uses the code.
Comment 6 Marek Fukala 2006-09-25 15:20:46 UTC 
fixed in release55_dev

Checking in TextEditorSupport.java;
/cvs/xml/core/src/org/netbeans/modules/xml/core/text/TextEditorSupport.java,v 
<--  TextEditorSupport.java
new revision: 1.26.2.1.2.1.16.1; previous revision: 1.26.2.1.2.1
done
Comment 7 Martin Schovanek 2006-09-26 15:04:13 UTC 
verified in release55_dev build
Comment 8 Petr Pisl 2006-09-26 18:26:36 UTC 
The fix is ok for me. It delete functionality, which is not used.
Comment 9 Petr Blaha 2006-09-27 08:59:33 UTC 
Mark issue as FIXED. Please, merge fix in release55 branch as well.
Comment 10 Marek Fukala 2006-09-27 10:07:57 UTC 
fixed in release55 branch

Checking in TextEditorSupport.java;
/cvs/xml/core/src/org/netbeans/modules/xml/core/text/TextEditorSupport.java,v 
<--  TextEditorSupport.java
new revision: 1.26.2.1.2.2; previous revision: 1.26.2.1.2.1
done
Comment 11 Martin Schovanek 2006-09-29 11:09:36 UTC 
verified in release55