This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 85044 - common schema import customizer is not really usable from wsdl editor
Summary: common schema import customizer is not really usable from wsdl editor
Status: VERIFIED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: Schema Tools (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Nathan Fiedler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-15 20:39 UTC by Ritesh Adval
Modified: 2006-10-19 15:45 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
files modified to fix in wsdl editor (43.26 KB, application/octet-stream)
2006-09-15 20:40 UTC, Ritesh Adval 		Details
browser UI (125.50 KB, application/octet-stream)
2006-09-26 19:45 UTC, Ritesh Adval 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ritesh Adval 2006-09-15 20:39:06 UTC 
Refer to bug 

http://xml.netbeans.org/issues/show_bug.cgi?id=83728

This bug really a code clean up issue to facilitate import customizer reuse in 
wsdl editor.


The schema import customizer is broken in wsdl editor.

 

You will see the problem as mentioned in the bug.

 

The problem is that when an xsd is imported in wsdl the namespace prefix is 
added to the inline schema, it should be added to wsdl definition.

 

The problem is in the way you are assuming the model where you want to add 
prefix is the model of your import element. This is not the case when adding 
the xsd import,

In wsdl document, here the model should be wsdl model where you want to add new 
prefix for each imported xsd.

 

Also in ExternalReferenceCustomizer calling initializeUI in constructor is 
broken on schema import dialog in wsdl editor.

The reason is that you are generating prefix etc here (getPrefix()) and for 
wsdl editor this getPrefix need to use wsdl model which is not available yet.

 

 

 

This is totally broken now. I had to copy this ExternalReferenceCustomizer in 
wsdl editor and fixed it.
Comment 1 Ritesh Adval 2006-09-15 20:40:20 UTC 
Created attachment 34032 [details]
files modified to fix in wsdl editor
Comment 2 Ritesh Adval 2006-09-26 19:45:16 UTC 
Created attachment 34540 [details]
browser UI
Comment 3 Ritesh Adval 2006-09-26 19:46:43 UTC 
Please ignore my last attachment browser UI, this was for a differnt bug.
Comment 4 Nathan Fiedler 2006-10-05 06:34:04 UTC 
Fixed in release55_dev branch.

Removed:
xml/wsdlui/src/org/netbeans/modules/xml/wsdl/ui/view/ExternalReferenceCustomizer.form
xml/wsdlui/src/org/netbeans/modules/xml/wsdl/ui/view/ExternalReferenceCustomizer.java

Modified:
xml/schema/schemaui/src/org/netbeans/modules/xml/schema/ui/nodes/categorized/customizer/ImportCustomizer.java
new revision 1.1.2.10.6.2
xml/schema/schemaui/src/org/netbeans/modules/xml/schema/ui/nodes/categorized/customizer/IncludeCustomizer.java
new revision 1.1.2.9.6.2
xml/schema/schemaui/src/org/netbeans/modules/xml/schema/ui/nodes/categorized/customizer/RedefineCustomizer.java
new revision 1.1.2.9.6.2
xml/wsdlui/src/org/netbeans/modules/xml/wsdl/ui/view/ImportSchemaCustomizer.java
new revision 1.1.2.3.6.2
xml/wsdlui/src/org/netbeans/modules/xml/wsdl/ui/view/ImportWSDLCustomizer.java
new revision 1.1.2.3.6.1
xml/wsdlui/src/org/netbeans/modules/xml/wsdl/ui/view/SchemaReferenceDecorator.java
new revision 1.1.2.1.14.2
xml/xamui/src/org/netbeans/modules/xml/xam/ui/customizer/ExternalReferenceCustomizer.java
new revision 1.1.2.15.6.3
Comment 5 Nathan Fiedler 2006-10-05 18:53:58 UTC 
As part of fixing issue 86397, which involves the same code as this issue, the
fix for this issue has been integrated to the release55 branch.
Comment 6 Andrei Chistiakov 2006-10-19 15:45:12 UTC 
Verified in build 061010_1.