This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 83952 - [A11Y] no mnemonics in popup menu for project view
Summary: [A11Y] no mnemonics in popup menu for project view
Status: RESOLVED WONTFIX
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Projects UI (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: A11Y, UI
Depends on: 70255 95539 95541
Blocks: 118523
  Show dependency tree
 
Reported: 2006-08-31 17:44 UTC by olegsukhodolsky
Modified: 2010-12-02 06:24 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description olegsukhodolsky 2006-08-31 17:44:06 UTC
I'm using NB 5.5 beta 2 and found that popup menu in Projects view has just one
mnemonic :(while it contains 20 items).  And this is very annoying to scroll
down in this menu (e.g. "set main project" is in the middle of this popup).
Comment 1 Jesse Glick 2006-08-31 18:43:35 UTC
BTW for the case of Set Main Project, you can just use Alt-F M from the main menu.
Comment 2 olegsukhodolsky 2006-08-31 20:54:36 UTC
yes I can, but what about other?  And what is the point to have context menu if
it is hard to use it (at least for people who do not like mouse as me :)
Comment 3 Jaromir Uhrik 2006-09-04 16:49:41 UTC
It is the policy not to use mnemonics in popup menus because items in popup
menus are dynamicly added to the popup menu (before its paint) according to the
context. It is not possible to forbid having 2 menu items with same mnemonic so
that no menu item has mnemonic by this strategy.
This behavior is not only in projects module but in all ide. Passing this issue
to ide category.
Comment 4 olegsukhodolsky 2006-09-04 17:35:59 UTC
It is an interesting approach.  You do not allow mnemonics in popups to not have
the same mnemonic twice, but you do have a lot if Alt+letter shortcuts which may 
conflict with mnemonics in menu bar ;)
Comment 5 Jaromir Uhrik 2006-09-04 18:34:06 UTC
Oleg, could you please be more specific and tell us mnemoics that have conflicts
in menu bar. Such conflicts are issues and must be filed in issuezilla and fixed
of course. Thanks in advance.
Comment 6 olegsukhodolsky 2006-09-04 18:47:47 UTC
Well, there is none now.  (At some (rather early) point "Profiler" menu had Alt-O
mnemonic which conflicts with go-to-source shortcut.)

My comment, not about existing conflict, but about some policies inconsistence.
Comment 7 Jaromir Uhrik 2006-09-05 09:22:28 UTC
This is the same problem as described in issue #16150. Changing this issue as
duplicate of the original one.

*** This issue has been marked as a duplicate of 16150 ***
Comment 8 Martin Krauskopf 2006-09-05 13:40:42 UTC
I've reopened that one.
Comment 9 Martin Krauskopf 2006-09-14 09:14:29 UTC
Actually this one is not dupe and can be fixed now since issue 16150 is not
valid anymore in JDK[567] (i.e. it is fixed). See comment from jglick Wed Sep 6
13:43:00 +0000 2006 in the issue 16150.
I suggest to make this an umbrella and a central place for discussion in the
case anybody see the reason why this should not be fixed. I'll file a bug
against j2se and apisupport projects.
Fix should be easy, just adding appropriate mnemonics to resources used by
LogicalViewProvider.createLogicalView().getActions(boolean) in each project-type.
Comment 10 jrojcek 2006-10-10 11:23:53 UTC
Make sure the contextual menu shows mnemonics only if the menu is invoked by keyboard.
Comment 11 Jesse Glick 2006-10-10 16:23:33 UTC
"Make sure the contextual menu shows mnemonics only if the menu is invoked by
keyboard." - I doubt this is currently the case. If this is required, a separate
bug needs to be filed in openide, subcomponent AWT/Swing, as that is orthogonal
to adding mnemonics to particular menu items.
Comment 12 olegsukhodolsky 2006-10-10 16:37:23 UTC
Actually I've filed such bug some time ago (look at 70255).
Comment 13 Jesse Glick 2006-10-10 16:42:13 UTC
I am not sure if issue #70255 is exactly what Jano was talking about, though it
may be related. Jano was saying, independent of L&F, mnemonics should be shown
iff S-F10 was used to post the popup.
Comment 14 Milan Kubec 2007-02-14 12:24:03 UTC
Martine, have you filed those issues against each project type? Should this
issue be marked as UMBRELLA then?
Comment 15 Martin Krauskopf 2007-02-14 12:37:05 UTC
Have done just now.
Comment 16 Lukas Hasik 2008-04-10 21:41:18 UTC
moving opened issues from TM <= 6.1 to TM=Dev
Comment 17 Tomas Danek 2008-09-09 15:19:30 UTC
Lukasi, you are perm-UI specialist, is this still valid? The only mnemonic i see in popup is F - Find...
Comment 18 Jesse Glick 2010-04-08 22:14:30 UTC
I have no idea what the UI spec requests or if this issue is still to be fixed.
Comment 19 Ondrej Langr 2010-04-13 14:49:38 UTC
I don't have any idea if this issue is to be fixed either. But it certainly does not classify to P3 according to current bug priority guidelines. 

What I know for sure is that permanent UI specs are not in place anymore so they'll not help us :-(.
Comment 20 Marian Mirilovic 2010-04-16 08:03:01 UTC
isn't this already fixed ?
Comment 21 Jesse Glick 2010-04-16 20:11:40 UTC
No, why do you say that? There is a mnemonic only for Find last I checked.
Comment 22 Jaromir Uhrik 2010-10-19 14:44:45 UTC
Jesse, why is there mnemonic for Find action only? Do you know how to fix this issue in some general way?
Thanks.
Comment 23 Jesse Glick 2010-10-19 15:12:23 UTC
(In reply to comment #22)
> why is there mnemonic for Find action only?

No particular reason; it just happens to be the same Action as one in the main menu which has a mnemonic.

> Do you know how to fix this issue in some general way?

No, just by fixing each possible menu item. I still have no clear idea of whether the mnemonics are wanted or unwanted.
Comment 24 draikes 2010-11-30 22:09:16 UTC
Hello, IMO, the mnemonics are not entirely necessary. I am a blind user of netbeans and JDeveloper, and I know that in the case of JDeveloper, it was decided that since there are so many conflicts between potential mnemonic keys and other shortcuts given the number of languages that JDeveloepr was going to be translated into, that it was better to just not force the issue.

It is true that at times it would be hlepful to have the mnemonics when a dialog or menu is quite large or cluttered, but usually when a user gets familiar with the products, he can navigate quite quickly even without the mnemonics.
Comment 25 Jesse Glick 2010-11-30 23:26:01 UTC
Mnemonic conflicts are managed by Swing; pressing the key repeatedly should cycle between the alternatives.

Anyway it seems there is no general desire for the mnemonics. So in core-main #d0b8f33f712a I made a general change that should suppress mnemonics on context menu items created using the normal Actions.connect, used by default if you just add an Action to a popup list. Editor context menu items do not seem to use this, and items in submenus like Local History and Refactoring will not necessarily pick up the change, but at least the mnemonics are gone from e.g. Find on a project, Properties on a source file, etc. You can always override this behavior with a custom PopupPresenter, or more simply by setting the action property popupText to some value including an ampersand.

If this change is unwanted, it can of course be reverted, but then the issue becomes _adding_ mnemonics to a lot of actions which currently lack them, to make context menus look more consistent.

BTW it seems that the Mac's Aqua L&F was already suppressing mnemonics on context menu items; or at least so I gather from unit tests. (I have no Mac to check on myself.)
Comment 26 Quality Engineering 2010-12-02 06:24:56 UTC
Integrated into 'main-golden', will be available in build *201012020001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/d0b8f33f712a
User: Jesse Glick <jglick@netbeans.org>
Log: #83952: do not show mnemonics on context menu items by default.