In the past, before the J2EE support was added to NetBeans the default server
concept had been used. This concept was then abandoned since it did not work
anymore. The problem could occur for example if the default server was Tomcat
then the EJB project, which was set to use the default server could not be
deployed to it, etc.
Even if the required API change will not be compatible it should not break
anything, since the current default server support does not work.
Created attachment 33503 [details]
Created attachment 33504 [details]
list of impacted interfaces:
Although this is an incompatible change, it should not break anything, since the
being removed API has been broken for quite a while and is not even fixable ->
using the API_REVIEW_FAST keyword.
Please review this API change
is this targetting 5.5? I would rather not as this seems to break the mevenide
j2ee specific codebase. While I don't have a problem with 6.0 timeframe, 5.5 is
too close to get a version out that supports both 5.0 and 5.5.
what is the intended replacement code algorithm supposed to look like? I mean
how do I find out what to fallback when server instance is not defined?
Yes, it is targeting 5.5, but if it is really a problem, we can postpone it till
Are you really sure that it would break the meven ide? If it does it means that
it relies on something that does not work properly, so it should be probably
Projects should use one of the Deployment.getServerInstanceIDs() methods to pick
a server they should be deployed to based on the projects requirements.
well, it's calling the methods that you want to remove, it calls super.<method>
in the subclasses and similar stuff. I keep the mevenide modules working on both
5.0 and 5.5/6.0, this change so late in the dev cycle would mean quite a bit of
testing for me and also the need to push a new version early enough so that
people don't get stuck when upgrading the IDE.
please postpone to 6.0 timeframe.
OK, lets postpone it to 6.0.
TM -> Dev
Created attachment 33581 [details]
Since this is more a clean up than an actual defect changing the type to TASK.
Milos is is the default server stuff still needed?
feel free to do it for 6.5, I'll accomodate the maven source code once it's done.
Should be done for 6.5.