This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 83495 - DnD of Web Service node to create Partner Link in BPEL
Summary: DnD of Web Service node to create Partner Link in BPEL
Status: VERIFIED FIXED
Alias: None
Product: soa
Classification: Unclassified
Component: BPEL (show other bugs)
Version: 5.x
Hardware: All All
: P1 blocker (vote)
Assignee: Alexey Yarmolenko
URL:
Keywords:
Depends on:
Blocks: 83253
  Show dependency tree
 
Reported: 2006-08-25 19:08 UTC by Michael Frisino
Modified: 2006-10-03 13:51 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Revised PartnerLink dialog (15.88 KB, application/octet-stream)
2006-09-11 12:31 UTC, Michael Frisino
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Frisino 2006-08-25 19:08:39 UTC
Useability issue. Users want easy integration b/t NB Web service projects and
BPEL. User wants to DnD web service into BPEL and have a partner link created
automatically.

Problem - today this is not possible. Today, user must 
1) use XML retrieve wizard to retrieve the specific WSDL files from web service
project and copy to bpel project. 
2) Then user must DnD wsdl from bpel project into bpel diagram.
3) user will probably also need to manually edit the wsdl file because NetBeans
web service wsdl files (jax-ws based) do not have end points defined.

1a) sometimes in new WS projects, there is NO wsdl files becasue NetBeans relies
on latest ws-jax and this will only create wsdl on server. So there is nothing
for user to copy even if they want to. Big problem.

Recommended solution:

User should be able to DnD WebService node from web service project into BPEL
diagram.
BPEL diagram should autoatically 
1)detect that this is coming from WebService project
2)automatically create Partner Link.
(for Jirka - should there be any dialog or should the PL just be created with a
default name? )

Caveat - this solution depends on following:
1) The source WS must have been deployed to AS prior to this DnD
2) AS must be running.

(question for Rico Cruz - is this only possible if AS is Sun AS? )
Comment 1 Michael Frisino 2006-08-25 19:14:27 UTC
Ah, there is need to ask user where the retreived wsdl should be placed. So
there is minimally a dialog asking for target directory choice.

As per design discussions, this assumes :

that the source WS has 1 and only 1 port type defined. It is because of this
assumption that we do not need UI to ask user to define PLT. We can assume there
is only one possible PLT.

that the BPEL project will be able to retrieive the wsdl (and all supporting
docs - closure)

that the BPEL project will be able to add new PLT (partner link type) to the
retrieved wsdl. 

that the BPEL diagram will be able to add import statement to the BPEL

that the BPEL diagram will be able add a new Partner Link to the BPEL

Note - DnD'ing the same WS twice should not result in additional PL, it should
just refresh the local wsdl documents. 




Comment 2 Jiri Kopsa 2006-09-06 17:36:47 UTC
I think there should be a confirmation dialog on DnD of a WebService to the BPEL
diagram, that would allow the user to provide additional information or confirm
suggested default values. The reasoning is that:
* this gesture is not that frequent for the dialog to be disturbing (as long as
it can be OKed with Enter key)
* the terms exposed in the pop up dialog won't be foreign to the user, it will
be consistent/aligned with partner link dialog (that pops up on DnD of a WSDL file).

In regards to visual feedback given on DnD - if there is an issue with the web
service or its WSDL file, negative visual feedback should be given:
* unavailable mouse pointer
* red ghost
* perhaps also a message explaining the issue on-place (as in Design View of XML
Schema Editor)
Comment 3 Todd Fast 2006-09-06 21:00:07 UTC
While I can see the role of a dialog here, I don't think there is a strict
requirement for it--all necessary information is deducible (though it would be
reasonable for the user to confirm). I'd also like to minimize the changes at
the UI level at this point in the release, so I vote that we do not add a dialog
in this iteration, and consider adding one in the next update.

-1
Comment 4 Jiri Kopsa 2006-09-07 16:50:06 UTC
If we show the dialog, it will be more clear, what is actually happening (a PL
and PLT is being created). Morover, there is a use case of a web service from
preexisting WSDL with (multiple) PLTs defined - ok, this one is corner case, but
anyway ...

Moreover, it really is not a distraction in workflow, as WS is not being DnDed
often. And as I suggested, this is also in sync with what we do for WSDLs. It
really does not breake end-to-end story...

I also think that the change to the UI is not drastical, as we will reuse
existing dialog.

+1 from over here

Comment 5 Todd Fast 2006-09-08 03:20:09 UTC
Code freeze is next week. I don't think there is time for this if you're
proposing a new dialog.
Comment 6 Jiri Kopsa 2006-09-08 08:42:10 UTC
Frankly, I was also more commenting on the general workflow and the fact that a
dialog would pop up; I was also unsure what will be the dialog, but as far as I
know, it won't be a new dialog, but an existing PL/PLT dialog (that pops up on
DnD of a WSDL). Can you confirm this Alexey?
Comment 7 Alexey Yarmolenko 2006-09-08 08:55:09 UTC
Yes, correct. The plan is to use the PL editing dialog.
Comment 8 Alexey Yarmolenko 2006-09-08 14:29:09 UTC
Current behavior is:
-Retrieve wsdl and all referenced resources for dropped WS project
-Store them in subfolder Partners/<ServiceName>, override all previous folder 
content
-Modify soap:address to use "localhost" instead of IP or domain name
-Show PL editor dialog

Comment 9 Jiri Kopsa 2006-09-08 14:56:23 UTC
What is the behaviour if the user cancels the dialog? Ultimately the system
should be in the state in which it was before the gesture started.
Comment 10 Alexey Yarmolenko 2006-09-08 19:29:11 UTC
Canceling dialog cancels just last stage of this process - PL creation. But 
all artifacts created during 1t stage(retrieveng wsdl and related documents) 
will remain intact.

In general case, when EJB project was DnD-ed for the first time, i can revert 
everything to initial state by removing corresponding folder under Partners 
folder. 

But I have no idea how to revert system to initial state, if there was some 
artifacts remaining from previous DnD.
Comment 11 Michael Frisino 2006-09-11 12:31:06 UTC
Created attachment 33756 [details]
Revised PartnerLink dialog
Comment 12 Jiri Kopsa 2006-09-11 16:00:30 UTC
I understand that implementing a rollback may be sometimes very difficult. Also,
If a gesture results in an immediate pop up dialog and that dialog is cancelled,
it is assumed that the system rolls back to the state before the gesture. So I'm
filling this as a P3 issue:
http://www.netbeans.org/issues/show_bug.cgi?id=84622

For Nikita (CCed): There should be 17 px above the Ok/Cancel buttons + a space
for a validation message; but it seems there is inappropriately more. Can this
be fixed? ...asigning to Nikita.
Comment 13 Victoria Zhukovskaya 2006-10-03 13:51:03 UTC
WinXP Coke061001

steps
1 create Webservice NewWebservice , add operation, deploy
2 drop on bpel diagram
3 property editor is opened  -  there is newly created PLT. press ok
4 Process Files on project tab  has node  Partners|NewWebservice |
NewWebservice.wsdl

all is ok