This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 78604 - Resolve clash issues in the area of glassfish logging library
Summary: Resolve clash issues in the area of glassfish logging library
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSP Parser (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Petr Pisl
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 78597
  Show dependency tree
 
Reported: 2006-06-20 15:32 UTC by Petr Jiricka
Modified: 2006-09-13 09:28 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2006-06-20 15:32:04 UTC
There is a clash in the area of glassfish logging (repackaged Apache
commons-logging) between NetBeans JSP parser and Creator built-in JSF 1.2
implementation. This needs to be resolved.
Comment 1 Petr Pisl 2006-06-20 18:13:50 UTC
The solution is to create a library wrapper module for
com.sun.org.apache.commons.** classes and all modules refer to that library
wrapper modules and it's now done on my disk. So if you agree I will commit it
tomorrow.

I created new module org-netbeans-libs-glassfish-logging, which is the wrapper
for classes com.sun.org.apache.commons.logging.** . The classes are taken from
glassfish build 48. The package com.sun.org.apache.commons.logging is expose as
a friend api. For now just jspparser is the only friend.

If nobody has a comment, I'm going to commit this. 
Comment 2 _ ludo 2006-06-21 09:29:28 UTC
I need to know more about his clash and these dependencies between the jsp
parser and JSF...
We might need to notice the ARC team about these dependancies, so please
describe more the issue.
Also, include someone from GF team (Jerome Dochez?) to review these dependancies
so that we can track them .
Finally, I am not sure about the lib name mentioning GlassFish. Please ask legal
about the name usage...For example, the plugin for AS 9 does not mention GF, and
use a different naming (o.n.m.sun.***)
Comment 3 Petr Pisl 2006-06-21 11:37:36 UTC
n the logging library there is a specific check, whether the class loaders of
the Log interface and the Log implementation is the same. If the classloaders
are different, then the getLogConstructor() throws new LogConfigurationException
("Invalid class loader hierarchy.  "  ....

So the jspparser has special classloader, which is constructed from classloader
of jsp parser module and some special jars like glassfish-jspparser.jar, which
contains logging library.  Problem is when an other module use logging as well,
then the jsp parser stops to work due to wrong inicialization of logging.

There is not any dependencies between jsp parser and JSF. The problem is that
both use the same logging libraries, which causes the described problem.

From the duplication libraries in NetBeans is better also separate the logging
library from jsp parser and create a module wrapper, which can be used by other
modules as well.

Regarding the name, we already have jarfile, which is called
glassfish-jspparser.jar. If you have any suggestion, give me know.
Comment 4 Petr Pisl 2006-06-21 14:10:17 UTC
The changes are now in the cvs 55 branch.
Comment 5 Petr Jiricka 2006-06-26 23:01:05 UTC
So can this be marked as fixed?
Comment 6 Petr Pisl 2006-06-28 16:15:52 UTC
Not yet. There is regression connecting with compilation single file. I will
close the isseu, when I will be sure, that the regression is fixed. 
Comment 7 Petr Pisl 2006-07-12 14:49:29 UTC
Now it looks like all problems are solved. Closing this task. 
Comment 8 Petr Pisl 2006-07-13 14:35:09 UTC
I would like to go with this through the fast track review, because we need to
add as friend module from Creator, which introduce cross-cluster dependency.

As result of this issue there is module wrapper for
com.sun.org.apache.commons.loggin.** library. This module expose the loggin
package as friend api and Creator modules need to access this classes as well.
We would like to add these modules as new friends:
com.sun.rave.libs.jsf.ri12
com.sun.rave.libs.apache.commons
Comment 9 Petr Pisl 2006-07-13 14:36:23 UTC
I forgot to assign to the apireview. See the last my comment. 
Comment 10 Petr Pisl 2006-07-14 08:20:30 UTC
There is the complete list of Creator modules, which will be friends:
com.sun.rave.libs.apache.commons
com.sun.rave.libs.jsf.ri12
com.sun.rave.j2ee14classloaderprovider
Comment 11 Petr Pisl 2006-07-18 17:20:52 UTC
I'm going to commit tomorrow the friend modules.
Comment 12 Petr Pisl 2006-07-19 11:53:16 UTC
The new friends are committed in the cvs. 
Comment 13 Jindrich Sedek 2006-09-13 09:28:50 UTC
v.