This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 77972 - Getting NPE during CVS Update
Summary: Getting NPE during CVS Update
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords: RANDOM
Depends on:
Blocks:
 
Reported: 2006-06-15 11:24 UTC by Martin Krauskopf
Modified: 2007-01-04 17:14 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
NPE (1.34 KB, text/plain)
2006-06-15 11:25 UTC, Martin Krauskopf
Details
npe1 (1.34 KB, text/plain)
2006-07-18 14:31 UTC, Martin Krauskopf
Details
NPE2 (1.73 KB, text/plain)
2006-08-28 15:04 UTC, Martin Krauskopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Krauskopf 2006-06-15 11:24:35 UTC
Happening relatively often -> P2. Also at least NPE itself should be easy to fix.
Comment 1 Martin Krauskopf 2006-06-15 11:25:11 UTC
Created attachment 31067 [details]
NPE
Comment 2 Maros Sandor 2006-07-14 12:13:26 UTC
Cannot be reproduced easily. Can you be more specific about your actions. Where
do you invoke Update from an on what context? Does it finish normally or do you
cancel the command? Does it throw any other (CVS) error?
Comment 3 Martin Krauskopf 2006-07-17 17:38:45 UTC
If I reproduce again I can bring more information (had been on vacation for last
10 days). But in the case of NPE you could at least use e.g. some kind of
assertion or some logging. Next time we would be more clever.
Comment 4 Martin Krauskopf 2006-07-18 14:31:03 UTC
release55 branch - fresh build

1) Create EAR project with EJB
2) Delete EJB project
3) Show changes on broken EAR project

One of scenario when did it happen to me. Attaching new stacktrace with new line
numbers.
Comment 5 Martin Krauskopf 2006-07-18 14:31:39 UTC
Created attachment 31961 [details]
npe1
Comment 6 Martin Krauskopf 2006-07-18 14:33:15 UTC
forgotten step:

1.5) commit EAR project into CVS repository
Comment 7 Martin Krauskopf 2006-07-21 09:40:39 UTC
Happened often also with project in NB_CVS (j2ee/utilities this time). The same
stacktrace.
Comment 8 Maros Sandor 2006-08-04 14:11:44 UTC
I wonder who keeps interrupting CVS threads. I assume you are not cancelling
updates manually.
Comment 9 Martin Krauskopf 2006-08-04 15:11:40 UTC
> I assume you are not cancelling updates manually.

No. Often happen when I do CVS -> Update from Menu. When I get rid of exception
dialog and do the same again it passes seamlessly.
Comment 10 Maros Sandor 2006-08-04 15:50:47 UTC
I know how to fix this but then some other exception will pop up saying the
command failed because its I/O was interrupted. Big improvement for me but will
that be improvement for you?
Comment 11 Martin Krauskopf 2006-08-04 15:59:32 UTC
Feel free to mark this fixed if you get rid of NPE and file a new issue (please
add me to CC list) which you encounter and then fix them. Not sure what exactly
are you asking me ;)
Comment 12 Maros Sandor 2006-08-04 16:18:25 UTC
This was a bit philosophical question ... I fix this and you will then open a
new issue because the command will still fail but for some other reason ;-)
Comment 13 Maros Sandor 2006-08-07 12:33:34 UTC
Fixed thread synchronization.

javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ExecutorSupport.java
1.47
javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/CommandRunnable.java
1.17
Comment 14 Martin Krauskopf 2006-08-28 15:04:17 UTC
Created attachment 33320 [details]
NPE2
Comment 15 Martin Krauskopf 2006-08-28 15:04:32 UTC
I did the Menu -> CVS -> "Show Changes" on project which was commited before
from command-line, but probably not so important. Just another RANDOM conditions
come together. Seems to be very similar stacktrace, which is strange...
Comment 16 Martin Krauskopf 2006-08-28 15:05:25 UTC
PS: today's morning own fresh build from trunk
Comment 17 Maros Sandor 2006-09-08 10:18:00 UTC
Ok, let's fix it by checking for the NPE, it is harmless anyway in this scenario.

/shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/update/UpdateExecutor.java,v
 <--  UpdateExecutor.java
new revision: 1.24; previous revision: 1.23