This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 76094 - performance.xsl and suite.xsl invalid for JDK1.4.2
Summary: performance.xsl and suite.xsl invalid for JDK1.4.2
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: xtest (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Jiri Skrivanek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-09 12:50 UTC by Jiri Skrivanek
Modified: 2007-01-24 08:35 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2006-05-09 12:50:09 UTC 
The following exception is thrown when you try to get transformer on JDK1.4.2_10
for performance.xsl and suite.xsl templates:

javax.xml.transform.TransformerConfigurationException:
javax.xml.transform.TransformerException:
javax.xml.transform.TransformerException: xsl:sort is not allowed in this
position in the stylesheet!

To test it use something like this:

    public static void main(String[] args) throws Exception {
        File dir = new File("D:\\Development\\cvs\\nb_all\\xtest\\lib\\xsl");
        File[] files = dir.listFiles();
        for(int i=0;i<files.length;i++) {
            if(!files[i].getName().endsWith("xsl")) {
                continue;
            }
            TransformerFactory tFactory =
javax.xml.transform.TransformerFactory.newInstance();
            StreamSource xslSource = new StreamSource(files[i]);
            try {
                Transformer transformer = tFactory.newTransformer(xslSource);
            } catch (Exception e) {
                System.out.println("FILE="+files[i]);
                System.out.println("EXCEPTION="+e.getMessage());
            }
        }
    }
Comment 1 Marian Mirilovic 2006-05-09 13:05:11 UTC 
Hmm, first of all investigation and stuff, I think it's time to upgrade, isn't
it ? We've already broke JDK 1.4.2 for NB , why not do so for xtest module ?
Comment 2 Jiri Skrivanek 2006-05-09 13:50:29 UTC 
I don't have any strong argument why not. It just seems to me better to not
break it without a good reason.
Comment 3 Marian Mirilovic 2006-05-09 14:06:01 UTC 
Good reason : save the time that has to be spend to fix this issue.

What do you think: it's reasonable, isn't it ?
Comment 4 Jiri Skrivanek 2006-05-09 14:37:15 UTC 
And spend time to test everything works with 1.5....
Comment 5 Marian Mirilovic 2006-05-09 14:44:33 UTC 
Well, I think you'll have to do testing as well in a near future, so what not now?

Anyway, Jirka everything is working (mean xtest), it has been running with this
change few months and nobody reported any problems. 

So, I really don't think we have to hold 1.4.2 compatibility just because
xtest-pes / beetle / xtest-db are still living in the old days.
Comment 6 Jiri Skrivanek 2006-05-09 15:45:28 UTC 
OK, I will test PES with JDK1.5 and fix possible problems.
Comment 7 Jiri Skrivanek 2006-09-13 15:51:55 UTC 
Fixed. xsl:sort has to be first element inside xsl:for-each.

/cvs/xtest/lib/xsl/performance.xsl,v  <--  performance.xsl
new revision: 1.6; previous revision: 1.5
done
Checking in suite.xsl;
/cvs/xtest/lib/xsl/suite.xsl,v  <--  suite.xsl
new revision: 1.15; previous revision: 1.14
Comment 8 Jiri Skrivanek 2007-01-24 08:35:02 UTC 
Verified.