This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 75162 - cannot edit web.xml
Summary: cannot edit web.xml
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: DD Editor (show other bugs)
Version: 5.x
Hardware: All All
: P1 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords:
: 75129 75163 75203 75360 (view as bug list)
Depends on:
Blocks: 75143 75176
  Show dependency tree
 
Reported: 2006-04-18 14:14 UTC by Lukas Jungmann
Modified: 2006-06-07 16:03 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Jungmann 2006-04-18 14:14:37 UTC
[200604180200 + jdk1.5.0_06-b05 + glassfish-b44]

-create Java EE 5 webapp
-open its web.xml in editor

=> following exception is being thrown after each key press while one is typing
java.lang.ClassCastException: org.netbeans.modules.j2ee.dd.impl.web.model_2_5.WebApp
	at
org.netbeans.modules.j2ee.ddloaders.web.DDDataObject.parseDocument(DDDataObject.java:195)
	at
org.netbeans.modules.j2ee.ddloaders.multiview.DDMultiViewDataObject$ModelSynchronizer.reloadModelFromData(DDMultiViewDataObject.java:250)
	at
org.netbeans.modules.xml.multiview.XmlMultiViewDataSynchronizer.reloadModel(XmlMultiViewDataSynchronizer.java:199)
	at
org.netbeans.modules.xml.multiview.XmlMultiViewDataSynchronizer$3.run(XmlMultiViewDataSynchronizer.java:69)
	at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:493)
[catch] at
org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:926)
Comment 1 Jiri Kovalsky 2006-04-19 10:15:12 UTC
*** Issue 75203 has been marked as a duplicate of this issue. ***
Comment 2 Petr Pisl 2006-04-20 12:34:35 UTC
*** Issue 75129 has been marked as a duplicate of this issue. ***
Comment 3 Petr Pisl 2006-04-20 12:36:30 UTC
Increasing this to P1. The regression doesn't influence only editing web.xml,
but as well all functionality which need to work with web.xml and dd API. 
Comment 4 Petr Pisl 2006-04-20 12:37:38 UTC
Increasing this to P1. The regression doesn't influence only editing web.xml,
but as well all functionality which need to work with web.xml and dd API. 
Comment 5 Marek Fukala 2006-04-20 15:04:34 UTC
I have modified the semantic of the DDProvider.getDDRoot() method to the
original meaning so now it returns just the XML descriptor content. There is a
new method DDProvider.getMergedDDRoot() which returns the merged s2b tree. This
change is rather a hotfix for this P1 since IMHO the whole situation about the
DDProvider metadata providing needs to be more think out.

We at least need to determine:
1) what clients needs the merged and non-merged DD metadata (at least the UI
editor needs just what is in the file)

2) how these clients will access the proper s2b tree - Will there be two methods
getDDRoot() and getMergedDDRoot() or just the getDDRoot() + clients which
requires the merged metadata will use MergedProvider to get it??)

So for now fixed in the way described above...

Checking in ddapi/src/org/netbeans/modules/j2ee/dd/api/web/DDProvider.java;
/cvs/j2ee/ddapi/src/org/netbeans/modules/j2ee/dd/api/web/DDProvider.java,v  <--
 DDProvider.java
new revision: 1.3.28.4.2.4; previous revision: 1.3.28.4.2.3
done
Checking in ddapi/src/org/netbeans/modules/j2ee/dd/impl/web/WebMergedProvider.java;
/cvs/j2ee/ddapi/src/org/netbeans/modules/j2ee/dd/impl/web/Attic/WebMergedProvider.java,v
 <--  WebMergedProvider.java
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Comment 6 Jiri Kovalsky 2006-04-24 06:34:03 UTC
*** Issue 75360 has been marked as a duplicate of this issue. ***
Comment 7 Marek Fukala 2006-04-24 09:53:24 UTC
*** Issue 75163 has been marked as a duplicate of this issue. ***
Comment 8 Lukas Jungmann 2006-06-07 16:03:11 UTC
v.