This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 72317 - Property makenbm.override.license not resolved against the project base directory
Summary: Property makenbm.override.license not resolved against the project base direc...
Status: RESOLVED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Andrei Badea
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-06 21:07 UTC by Andrei Badea
Modified: 2006-10-23 16:41 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Badea 2006-02-06 21:07:39 UTC
It is instead resolved against the JVM's working directory, so it doesn't work
when invoking Create NBM from the IDE. 

Proposed fix:

Index: antsrc/org/netbeans/nbbuild/MakeNBM.java
===================================================================
RCS file: /cvs/nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java,v
@@ -766,7 +766,7 @@
   protected void overrideLicenseIfNeeded() {
     if( overrideLicense()) {
       license = new Blurb() ;
-      license.setFile( new File( getLicenseOverride())) ;
+      license.setFile( getProject().resolveFile( getLicenseOverride())) ;
     }
   }

Please reassign to me if you agree with the fix but don't have time to commit
it, I will.
Comment 1 Jesse Glick 2006-02-06 21:43:14 UTC
Sure. But not a problem if you just pass an absolute path to begin with.
Comment 2 Andrei Badea 2006-02-06 22:45:18 UTC
You are right, I could have just used ${basedir}. Still commiting the fix, since
I think it matches the user expectation.

Checking in antsrc/org/netbeans/nbbuild/MakeNBM.java;
/cvs/nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java,v  <--  MakeNBM.java
new revision: 1.66; previous revision: 1.65
done