See also issue 61313.
I just know that Zajo and Radek talked a lot about this feature offline in the
office ;). Just in the case you are planning to work on it... CC
After Zajo's great progress with issue 54161 it should be now relatively easy to
implement this one -> P1.
Also original UI spec should be rewritten, since currently it specifies the node
to be only read-only. There should be probably special Tab in Customizer ->
Libraries similar to J2SE project (Test Module Dependencies) and the node in
Logical View should behave in the similar way to the module dependencies node.
Jesse or/and Martine, could you review attached patch (created against
apisupport/project) for adding/removing testdependencies? Tests are passing,
but... Thanks in adavnce
Created attachment 33764 [details]
Patch - apply on apisupport/project
mk1: I would move testEqualsAndHashCodeMethodsOfTestModuleDependency() rather to
mk2: Equal could do better. See attached failing test.
mk3: Maybe I would wait with commit until those new methods are needed by some
actual implemenation - i.e. by the GUI. Not sure if you and/or Zajo are
planning to work on it(?)
Created attachment 33767 [details]
Created attachment 36247 [details]
Unit test lib node patch
Working patch attached, feature + tests implemented. In future phases probably
some refactoring will be done in order to decrease code duplicity with Libraries
Can you review the patch before i commit? If there are no objections and you
find it good and not dangerous, i'll commit to trunk. Thanks.
- seems that you are working with JDK 6 --> javax.swing.GroupLayout -->
uncompilable on JDK 5
- java.lang.Runnables which are not run in UnitTestLibrariesNodeTest???
- duplicate import of "java.util.Map" in UnitTestLibrariesNode
- empty lines in o/n/m/a/p/ui/customizer/Bundle.properties
- unneeded TestModuleDependencyTest.tearDown()
- UnitTestLibrariesNode:515 could be deleted....
- ...run PMD ;)
Not for M5 - bugs only.
>- seems that you are working with JDK 6 --> javax.swing.GroupLayout -->
> uncompilable on JDK 5
Fixed, patch is now compilable with 1.5
>- java.lang.Runnables which are not run in UnitTestLibrariesNodeTest???
Rewritten test, for now without any thread sync, if it fails sometimes, i'll try
to make more reliable.
>- duplicate import of "java.util.Map" in UnitTestLibrariesNode
>- empty lines in o/n/m/a/p/ui/customizer/Bundle.properties
Empty lines removed.
>- unneeded TestModuleDependencyTest.tearDown()
>- UnitTestLibrariesNode:515 could be deleted....
>- ...run PMD ;)
Yes, i admit there was some useless code:)
Thanks a lot for your time spent on this, attaching new patch, feel free to
comment again. Finally, if there are no objections, i'll commit (after M5 is done).
Created attachment 36321 [details]
patch version 2
M5 is branched so you can commit to trunk at your leisure.
Fixed in trunk. Log attached.
Created attachment 36524 [details]
Please update apisupport/www/60-ui.html as needed.
finally updated UI spec.
Checking in 60-ui.html;
/cvs/apisupport/www/60-ui.html,v <-- 60-ui.html
new revision: 1.2; previous revision: 1.1