This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 71439 - Branding changes may not be visible (layer masking indeterminate)
Summary: Branding changes may not be visible (layer masking indeterminate)
Status: RESOLVED INVALID
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Martin Kozeny
URL:
Keywords:
Depends on: 141925
Blocks: 70884
  Show dependency tree
 
Reported: 2006-01-16 12:54 UTC by Jaroslav Tulach
Modified: 2016-05-25 06:16 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2006-01-16 12:54:22 UTC
In my contrib/sampleapps/htmleditor I created a module addons where I wanted 
to keep all brandings. I have modified its layer to override files provided by 
component palette and favorites modules (explicitly to show their components 
by default). To my surprise, palette was visible and favories were not!  
 
This is very likely caused by ordering of modules on startup. As a rule 
(enforced by commit validation) if a module overrides a resource of another, 
it needs a dependency. 
 
So I tried to add dependency from UI - worked for component palette (as it has 
an API) but not for favorites - the build failed. I had to go to project.xml 
and keep just runtime deps there. 
 
Imho this can be hardly discovered by anyone except netbeans authors, so I 
would suggest the layer branding support to automatically add a runtime dep on 
modules which resources are overriden.
Comment 1 Jesse Glick 2006-01-17 18:48:51 UTC
There is no branding support currently from the UI, but see issue #70884. That
could add deps for you when branding existing layer items.

You do not need to edit project.xml directly - you can just turn off the
checkbox "use .... packages during compilation" in module dep GUI.

*** This issue has been marked as a duplicate of 70884 ***
Comment 2 Jaroslav Tulach 2006-01-18 07:24:39 UTC
"There is no branding support currently from the UI" - there is, just create a  
module and edit its layer in context.  
  
I do not think that you can trade a defect for a feture, that is why I am  
reopening this bug: the support is there and in fact is broken, because  
without the runtime dependencies it creates a false impression that one can 
edit any layer and the changes will be visible.  
Comment 3 Jesse Glick 2006-01-19 05:39:06 UTC
Whatever you prefer, but it would only be solved as part of issue #70884.
Comment 4 Jesse Glick 2008-07-30 03:33:26 UTC
Do not want to introduce artificial dependencies just for layer overrides. See issue #141925.
Comment 5 Jesse Glick 2010-02-22 14:20:54 UTC
Would be feasible to solve using a weight attribute that would be added to any edited layer entry.