This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 70643 - I18N - Actions are not from bundle
Summary: I18N - Actions are not from bundle
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Options&Settings (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jan Jancura
URL:
Keywords: I18N
: 70823 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-12-20 14:46 UTC by Marek Grummich
Modified: 2008-12-22 21:38 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Options window (39.04 KB, image/png)
2005-12-20 14:47 UTC, Marek Grummich
Details
Screenshot after fix (25.85 KB, image/png)
2005-12-22 11:36 UTC, Max Sauer
Details
Screenshot (22.88 KB, image/png)
2006-01-03 10:08 UTC, Marek Grummich
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Grummich 2005-12-20 14:46:17 UTC
Build 200512192030 + pseudo

Summary is selfexplaining, but look at the attached screenshot
Comment 1 Marek Grummich 2005-12-20 14:47:02 UTC
Created attachment 27978 [details]
Options window
Comment 2 Jan Jancura 2005-12-21 16:23:00 UTC
Fixed in trunk. Fix is not complicated.


cvs diff -- Bundle.properties EditorBridge.java LayersBridge.java (in directory
C:\Hanz\Dev\trunk\editor\options\src\org\netbeans\modules\options\keymap)
Index: Bundle.properties
===================================================================
RCS file:
/cvs/editor/options/src/org/netbeans/modules/options/keymap/Bundle.properties,v
retrieving revision 1.13
diff -r1.13 Bundle.properties
65c65
< 
---
> CTL_Other=Other
Index: EditorBridge.java
===================================================================
RCS file:
/cvs/editor/options/src/org/netbeans/modules/options/keymap/EditorBridge.java,v
retrieving revision 1.9
diff -r1.9 EditorBridge.java
26a27
> import java.util.MissingResourceException;
39a41
> import org.openide.ErrorManager;
42a45
> import org.openide.util.NbBundle;
61c64,66
<                 if (category == null) category = "Other";
---
>                 if (category == null) 
>                     category = NbBundle.getMessage 
>                         (EditorBridge.class, "CTL_Other");             // NOI18N
69c74
<             actions.remove ("Hidden");
---
>             actions.remove ("Hidden");                                 // NOI18N
382a388,397
>             String bundleName = (String) categories [i].getAttribute 
>                 ("SystemFileSystem.localizingBundle");
>             if (bundleName != null)
>                 try {
>                     categoryName = NbBundle.getBundle (bundleName).getString (
>                         categories [i].getPath ()
>                     );
>                 } catch (MissingResourceException ex) {
>                     ErrorManager.getDefault ().notify (ex);
>                 }
cvs diff -- Bundle.properties mf-layer.xml (in directory
C:\Hanz\Dev\trunk\editor\options\src\org\netbeans\modules\options\editor\)
Index: Bundle.properties
===================================================================
RCS file:
/cvs/editor/options/src/org/netbeans/modules/options/editor/Bundle.properties,v
retrieving revision 1.8
diff -r1.8 Bundle.properties
30a31,47
> 
> #Action Category Names
> OptionsDialog/Actions/Build=Build
> OptionsDialog/Actions/CVS=CVS
> OptionsDialog/Actions/Edit=Edit
> OptionsDialog/Actions/File=File
> OptionsDialog/Actions/Form=Form
> OptionsDialog/Actions/GoTo=Go To
> OptionsDialog/Actions/Help=Help
> OptionsDialog/Actions/Refactor=Refactor
> OptionsDialog/Actions/Run=Run
> OptionsDialog/Actions/Source=Source
> OptionsDialog/Actions/Tools=Tools
> OptionsDialog/Actions/View=View
> OptionsDialog/Actions/Window=Window
> OptionsDialog/Actions/System=System
> OptionsDialog/Actions/XML=XML
Index: mf-layer.xml
===================================================================
RCS file: /cvs/editor/options/src/org/netbeans/modules/options/editor/mf-layer.xml,v
retrieving revision 1.20
diff -r1.20 mf-layer.xml
77a78
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
100a102
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
166a169
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
211a215
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
249a254
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
266c271,272
<             <folder name="Go To">
---
>             <folder name="GoTo">
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
321a328
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
341a349
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
388a397
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
462a472
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
479a490
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
532a544
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
549a562
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
638a652
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
670a685
>                 <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.netbeans.modules.options.editor.Bundle"/>
Comment 3 Tomas Hurka 2005-12-21 16:45:15 UTC
I reviewed the fix and it can be merged to release50 branch.
Comment 4 Max Sauer 2005-12-22 11:35:41 UTC
I haven't encountered any problems with the fix inside trunk build
(200512211900). For the appearance, see screenshot 'scr.png'.
Comment 5 Max Sauer 2005-12-22 11:36:32 UTC
Created attachment 28035 [details]
Screenshot after fix
Comment 6 Jan Jancura 2006-01-02 10:21:02 UTC
*** Issue 70823 has been marked as a duplicate of this issue. ***
Comment 7 Jan Jancura 2006-01-03 09:54:09 UTC
fixed in release50 branch:

cvs commit -m "70643  I18N - Actions  are not from bundle" (in directory
C:\Hanz\Dev\release50\editor\options\src\org\netbeans\modules\options\)
cvs commit: Examining .
cvs commit: Examining codetemplates
cvs commit: Examining colors
cvs commit: Examining editor
cvs commit: Examining general
cvs commit: Examining generaleditor
cvs commit: Examining indentation
cvs commit: Examining keymap
cvs commit: Examining macros
Checking in editor/Bundle.properties;
/cvs/editor/options/src/org/netbeans/modules/options/editor/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.8.8.1; previous revision: 1.8
done
Checking in editor/mf-layer.xml;
/cvs/editor/options/src/org/netbeans/modules/options/editor/mf-layer.xml,v  <--
 mf-layer.xml
new revision: 1.20.2.1; previous revision: 1.20
done
Checking in keymap/Bundle.properties;
/cvs/editor/options/src/org/netbeans/modules/options/keymap/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.13.2.1; previous revision: 1.13
done
Checking in keymap/EditorBridge.java;
/cvs/editor/options/src/org/netbeans/modules/options/keymap/EditorBridge.java,v
 <--  EditorBridge.java
new revision: 1.8.2.2; previous revision: 1.8.2.1
done
Checking in keymap/LayersBridge.java;
/cvs/editor/options/src/org/netbeans/modules/options/keymap/LayersBridge.java,v
 <--  LayersBridge.java
new revision: 1.7.2.1; previous revision: 1.7
done

***** CVS exited normally with code 0 *****
Comment 8 Marek Grummich 2006-01-03 10:07:25 UTC
Hanzi, I don't know who form QA verified this issue in 5.1 (trunk), but if I use
200601021900+pseudolocalization, I have two 'Other' nodes - look at the attached
screenshot.
Comment 9 Marek Grummich 2006-01-03 10:08:26 UTC
Created attachment 28138 [details]
Screenshot
Comment 10 Jan Jancura 2006-01-04 09:05:54 UTC
fixed in trunk & release50 branches:

Checking in LayersBridge.java;
/cvs/editor/options/src/org/netbeans/modules/options/keymap/LayersBridge.java,v
 <--  LayersBridge.java
new revision: 1.9; previous revision: 1.8
done
cvs commit -m "70643 I18N - Actions  are not from bundle" -- LayersBridge.java
(in directory
C:\Hanz\Dev\release50\editor\options\src\org\netbeans\modules\options\keymap)
Checking in LayersBridge.java;
/cvs/editor/options/src/org/netbeans/modules/options/keymap/LayersBridge.java,v
 <--  LayersBridge.java
new revision: 1.7.2.2; previous revision: 1.7.2.1
done
Comment 11 Marek Grummich 2006-01-05 12:57:18 UTC
Verified in the build 200601042030 (5.0)