This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 70237 - I18N - fontsize - smaller fonts than default in cmp mapping window
Summary: I18N - fontsize - smaller fonts than default in cmp mapping window
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 8 (show other bugs)
Version: 5.x
Hardware: Sun All
: P3 blocker (vote)
Assignee: _ pcw
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2005-12-12 05:20 UTC by Ken Frank
Modified: 2006-08-19 01:25 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
cmp window (20.87 KB, image/gif)
2005-12-12 05:22 UTC, Ken Frank
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2005-12-12 05:20:16 UTC
For zh l10n, they need the font size to be at least 14 point, due to
needing it at that size for clarity on some platforms, where the default ide
11 pt font zh fonts are not clear enough and they assign an ide font size
of 14 in a bundle value.

In cmp mappings window, there are 2 parts (see attached) that are smaller than
the default; in gif, I'm running at 16 pt so smaller might be ok, but user runnng
zh localized at 14 pt, these smaller lines will be at 13 or 12 point, which
is too small. (and user should not need to run ide with --fontsize arg
just for this case)

ken.frank@sun.com
Comment 1 Ken Frank 2005-12-12 05:22:31 UTC
Created attachment 27725 [details]
cmp window
Comment 2 Petr Jiricka 2005-12-12 13:41:22 UTC
This is appserver plugin UI.
Comment 3 _ pcw 2005-12-12 22:56:01 UTC
There are other problems with this particular piece of text, namely that it
shows up in blue (at least on windows, Solaris/JDS too I think) instead of
black, it's a different font and pointsize, and lastly, it's a titled border,
which is quite different from how all the rest of the customizer UI is done (and
probably the cause of the pointsize difference.)

This piece of UI comes from persistence-tools-support.jar, which makes it
somewhat difficult to fix w/o directly rebuilding the jar, which we have not had
to do yet for 5.0.  I will see what remedies exist.

I have to ask though, is this really a P2?  This bug existed in 4.1 and noone
reported it, even though it's pretty obvious when you look at the display for
this page (because the title is a clashing color and different font/pointsize,
even in English).
Comment 4 _ pcw 2005-12-12 23:18:26 UTC
I'll take a wild guess and say that the reason it doesn't follow any standard
font recommendations (e.g. --fontSize and current typeface) is because the code
to set the title hardcoded the font object to use:

setBorder(new javax.swing.border.TitledBorder(null, title,
javax.swing.border.TitledBorder.DEFAULT_JUSTIFICATION,
javax.swing.border.TitledBorder.DEFAULT_POSITION, new java.awt.Font("Dialog", 0,
12)));
Comment 5 _ pcw 2005-12-13 00:15:09 UTC
Fixing this is difficult.  The easy place to fix it is at the source,
com.sun.jdo.modules.persistence.mapping.ejb.ui.panels.BeanMappingPanel.java in
persistence-tools-support.java.  However, there is no real process for
rebuilding this jar, and frankly I think it's far to risky for such a trivial bug.

I looked into wrapping the panel and replacing the title.  It's not difficult,
but I discovered that certain controls inside the panel can reset the title if
they are used.  This means property listeners to catch the right changes, etc.
to make sure that we prevent the original border & title from being reset.

If the powers that be feel that this is really a P2 bug and needs fixing for
5.0, I will write up the necessary patch using this method.  My opinion though
is that this is not a P2.  If it wasn't important to fix for 4.1, I don't see
why it is important now.  I should point out that the label in question does not
contain any imformation that isn't also visible elsewhere in this customizer
(specifically the bean name).  In fact, I have reached the conclusion that for
our use case, the title is redundant and should simply be removed entirely.
Comment 6 Ken Frank 2005-12-13 01:39:21 UTC
Comments below make sense to me - esp if it involves code change to other cvs,
could be too risky now as long as
for zh locale, which uses 14pt font as a default, the items in the smaller font
which
may be not be as visible to user due to font quality on some unix, would not
confuse user -
that is mainly why was at p2 to start with.  If thats ok, please make p3, if 
it might not be ok, maybe just waive it and leave at p2 ?

There is a resize bug on parts of this same window - ior tab  - but probably
does not involve the smaller fontsize situation here.

ken.frank@sun.com
Comment 7 _ pcw 2005-12-13 05:42:29 UTC
Lowering to P3.  If someone disagrees, please feel free to raise back to P2 with
justification.
Comment 8 _ pcw 2006-08-19 01:25:54 UTC
Fixed.  Actually I removed the title completely as it was redundant for our use
case (name of bean is at top of customizer -- no need to show it twice).