Bug 68861 - Expose XMLDefaultTokenContext as friend API for web/jspssyntax
Expose XMLDefaultTokenContext as friend API for web/jspssyntax
Status: RESOLVED FIXED
Product: xml
Classification: Unclassified
Component: Text-Edit
5.x
All Windows XP
: P2 (vote)
: 5.x
Assigned To: apireviews
issues@xml
: API, API_REVIEW_FAST
Depends on:
Blocks: 54465
  Show dependency treegraph
 
Reported: 2005-11-16 23:06 UTC by Petr Jiricka
Modified: 2007-09-25 01:33 UTC (History)
0 users

See Also:
Issue Type: TASK
:


Attachments
The new API class (2.06 KB, text/plain)
2005-11-16 23:07 UTC, Petr Jiricka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2005-11-16 23:06:57 UTC
I would like to expose class XMLDefaultTokenContext from module xml/text-edit as
friend API for module web/jspsyntax. At the same time, it would be moved to
package org.netbeans.modules.xml.text.api.

This would eliminate the implementation dependency between these two modules,
see also issue 54465.

The proposal is not to design new API, just to formalize the current contract
that already exists in the form of implementation dependency.
Comment 1 Petr Jiricka 2005-11-16 23:07:58 UTC
Created attachment 27017 [details]
The new API class
Comment 2 Petr Jiricka 2005-11-16 23:09:50 UTC
Requesting a fast track review.
Comment 3 Miloslav Metelka 2005-11-17 12:58:45 UTC
XMLTokenIDs will get exposed as well, right?
Comment 4 Petr Jiricka 2005-11-20 20:03:58 UTC
No, I was not planning to expose it, as it is not needed outside this module.
Should I?
Comment 5 Miloslav Metelka 2005-11-20 23:04:49 UTC
Depends on whether you need to depend on the token ids defined in the
XMLTokenIDs. I thought that you want to but if not then you do not need to
publish XMLTokenIDs.
Comment 6 Petr Jiricka 2005-11-23 17:00:55 UTC
Done.

Checking in nbproject/project.xml;
/cvs/xml/text-edit/nbproject/project.xml,v  <--  project.xml
new revision: 1.6; previous revision: 1.5
done
RCS file:
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/api/XMLDefaultTokenContext.java,v
done
Checking in src/org/netbeans/modules/xml/text/api/XMLDefaultTokenContext.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/api/XMLDefaultTokenContext.java,v
 <--  XMLDefaultTokenContext.java
initial revision: 1.1
done
Checking in src/org/netbeans/modules/xml/text/completion/SyntaxQueryHelper.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/completion/SyntaxQueryHelper.java,v
 <--  SyntaxQueryHelper.java
new revision: 1.14; previous revision: 1.13
done
Checking in src/org/netbeans/modules/xml/text/indent/XMLFormatter.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/indent/XMLFormatter.java,v
 <--  XMLFormatter.java
new revision: 1.22; previous revision: 1.21
done
Checking in src/org/netbeans/modules/xml/text/syntax/XMLDefaultSyntax.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLDefaultSyntax.java,v
 <--  XMLDefaultSyntax.java
new revision: 1.13; previous revision: 1.12
done
Removing src/org/netbeans/modules/xml/text/syntax/XMLDefaultTokenContext.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLDefaultTokenContext.java,v
 <--  XMLDefaultTokenContext.java
new revision: delete; previous revision: 1.6
done
Checking in src/org/netbeans/modules/xml/text/syntax/XMLOptions.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLOptions.java,v 
<--  XMLOptions.java
new revision: 1.12; previous revision: 1.11
done
Checking in src/org/netbeans/modules/xml/text/syntax/XMLSettingsInitializer.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLSettingsInitializer.java,v
 <--  XMLSettingsInitializer.java
new revision: 1.21; previous revision: 1.20
done
Checking in src/org/netbeans/modules/xml/text/syntax/XMLSyntaxSupport.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLSyntaxSupport.java,v
 <--  XMLSyntaxSupport.java
new revision: 1.27; previous revision: 1.26
done
Checking in src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java,v 
<--  XMLTokenIDs.java
new revision: 1.3; previous revision: 1.2
done
Checking in
src/org/netbeans/modules/xml/text/syntax/dom/ProcessingInstructionImpl.java;
/cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/dom/ProcessingInstructionImpl.java,v
 <--  ProcessingInstructionImpl.java
new revision: 1.6; previous revision: 1.5
done

Checking in nbproject/project.xml;
/cvs/web/jspsyntax/nbproject/project.xml,v  <--  project.xml
new revision: 1.14; previous revision: 1.13
done
Checking in src/org/netbeans/modules/web/core/xmlsyntax/JspXMLTokenContext.java;
/cvs/web/jspsyntax/src/org/netbeans/modules/web/core/xmlsyntax/JspXMLTokenContext.java,v
 <--  JspXMLTokenContext.java
new revision: 1.2; previous revision: 1.1
done

Checking in cluster-impl-deps.txt;
/cvs/ide/golden/cluster-impl-deps.txt,v  <--  cluster-impl-deps.txt
new revision: 1.8; previous revision: 1.7
done
Checking in friend-packages.txt;
/cvs/ide/golden/friend-packages.txt,v  <--  friend-packages.txt
new revision: 1.10; previous revision: 1.9
done
Checking in impl-deps.txt;
/cvs/ide/golden/impl-deps.txt,v  <--  impl-deps.txt
new revision: 1.43; previous revision: 1.42
done


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo