This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Hello, I have a class extended form Object and the "Find" command in Toolbars work fine, but if I select a class extended from JFrame or JPanel whit form asosiated, the "Find" command in Toolbars appears disabled. Carlos
It seems that the ActionMap in lookup is not correctly updated. Probably an issue of multiview - reassigning for evaluation. Note that the Find action is correctly enabled when you open the form by Edit action. The Find action is not enabled if you open the form by Open action and then switch to the Source tab (but Ctrl+F shortcut works even it this case).
*** Issue 69952 has been marked as a duplicate of this issue. ***
*** Issue 65577 has been marked as a duplicate of this issue. ***
Too late for NB5.0, please reevaluate.
possibly related to #81117 ?
This issue affects everyone with a multiview and ActionMaps installed in the MultiViewElements -- raising the priority (will attach a simple test case).
Created attachment 34349 [details] simple test case (NB module project)
*** Issue 81374 has been marked as a duplicate of this issue. ***
depends on resolution of #81117, might be a duplicate, but for sure can tell once 81117 is fixed.
since 81117 was moved to editor, moving this one as well. according to my evaluation they have the same root of the problem
I was able to reproduce and I'll attempt to fix this on the editor side.
The problem is in fact in the utilities module. The editor properly installs its find action impl into the jeditorpane so it should work fine. However the utilities module installs its own find action impl into the top component's action map under some circumstances in the FindActionManager. Normal CloneableEditor is skipped but the exclusion does not work for multiview case. The output from the logger for CallbackSystemAction follows. Correct state for the non-multiview editor (and also expected state for Source view of multiview): FINE: Action for key: org.openide.actions.FindAction is: org.netbeans.editor.ext.ExtKit$FindAction@969129 Incorrect state after switch from design view to source view: FINE: Action for key: org.openide.actions.FindAction is: org.openide.util.actions.NodeAction$DelegateAction@1b1c85e[delegate=org.netbeans.modules.search.SearchPerformer@2c842c] Attaching a possible fix for the utilities module. The MultiViewCloneableTopComponent is not public so I've only added class name check which is ugly of course but could be considered as a minimalistic patch for 5.5.
Created attachment 34587 [details] Patch for the utilities module.
Reassigning to utilities module.
instead of checking CloneableEditor, one should check for CloneableEditorSupport.Pane interface which covers both multiview components and the CloneableEditor
Fixed in the trunk - using CloneableEditorSupport.Pane as Milos Kleint suggested. Modified file: utilities/src/org/netbeans/modules/search/FindActionManager.java (1.10) Diff: http://utilities.netbeans.org/source/browse/utilities/src/org/netbeans/modules/search/FindActionManager.java?r1=1.9&r2=1.10&diff_format=u
Committed to branch 'release55_dev'. Modified file: utilities/src/org/netbeans/modules/search/FindActionManager.java (1.8.32.1.14.1) Diff: http://utilities.netbeans.org/source/browse/utilities/src/org/netbeans/modules/search/FindActionManager.java?r1=1.8.32.1&r2=1.8.32.1.14.1&diff_format=u
Created attachment 34605 [details] binary patch for branch 'release55_dev'
I attached a binary patch for branch 'release55_dev' (for testing purposes).
Created attachment 34608 [details] source code patch for branch 'release55'
Created attachment 34609 [details] binary patch for branch 'release55'
I have attached a source code patch and also a binary patch for branch 'release55'. To apply the binary patch, download the .jar file and put it to subdirectory ide7/modules/patches/org-netbeans-modules-utilities of your NetBeans installation directory. (You may need to create the "patches" directory first.)
verified by QA, can be merged to release55 branch
Committed to branch 'release55'. Modified file: utilities/src/org/netbeans/modules/search/FindActionManager.java (1.8.32.2) Diff: http://utilities.netbeans.org/source/browse/utilities/src/org/netbeans/modules/search/FindActionManager.java?r1=1.8.32.1&r2=1.8.32.2&diff_format=u