This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 68200 - [GTK] Selected Tab is hardly visible
Summary: [GTK] Selected Tab is hardly visible
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords: GTK
Depends on:
Blocks:
 
Reported: 2005-11-07 09:38 UTC by Martin Krauskopf
Modified: 2008-12-22 22:38 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Tabs.png (15.51 KB, image/png)
2005-11-07 09:39 UTC, Martin Krauskopf
Details
Screenshot showing view tabs and editor tabs (5.71 KB, image/png)
2006-09-09 16:52 UTC, R Ramos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Krauskopf 2005-11-07 09:38:47 UTC
Under GTK, the Tab of the selected Document is hardly visible. See the attached
screenshot. SwitcherTableItem is selected. It makes poor usability on Mustang
with GTK L&F.
Should be simplefix I believe. If you don't have enough time, please give me
some tips, where should I look and I would try it and eventually attach a patch.
Thanks.
Comment 1 Martin Krauskopf 2005-11-07 09:39:18 UTC
Created attachment 26670 [details]
Tabs.png
Comment 2 Milos Kleint 2005-11-14 09:18:58 UTC
you want to look at the core/swing/tabcontrol module.
BasicScrollingTabDisplayerUI  class I guess, some L&Fs have custom subclasses,
the gtk doesn't so far.
reassigning as I don't have gtk on any of my computers..

Comment 3 Martin Krauskopf 2005-11-15 08:53:39 UTC
Thanks to Milos and Dafe for their clues where should I look. Fixed.

Checking in swing/tabcontrol/plaf/WinClassicEditorTabCellRenderer.java; 1.9 -->
1.10;
Checking in swing/tabcontrol/plaf/WinClassicViewTabDisplayerUI.java; 1.21 --> 1.22;
Comment 4 Jaromir Uhrik 2006-01-16 15:44:42 UTC
Marking this issue as VERIFIED since the issue reporter == issue owner.
Comment 5 R Ramos 2006-09-09 16:50:42 UTC
I am missing something here?
The original screenshot looks great compared with the screenshot I have attached
now.
The pic reflects the hardcoded settings:

GTK_TABBED_PANE_BACKGROUND_1 = new Color(100, 100, 100);
GTK_TABBED_PANE_BACKGROUND_2 = new Color(255, 255, 255);

in the files:
WinClassicEditorTabCellRenderer.java
WinClassicViewTabDisplayerUI.java

That makes the text hardly readable.
Comment 6 R Ramos 2006-09-09 16:52:11 UTC
Created attachment 33734 [details]
Screenshot showing view tabs and editor tabs
Comment 7 R Ramos 2006-09-09 20:01:07 UTC
I think the following settings would be acceptable for readability and selection
visibility:

GTK_TABBED_PANE_BACKGROUND_1 = new Color(255, 255, 255);//white
GTK_TABBED_PANE_BACKGROUND_2 = UIManager.getColor("TabbedPane.background");

Comment 8 Martin Krauskopf 2006-09-10 17:48:12 UTC
> I am missing something here? The original screenshot looks great compared
> with the screenshot I have attached now.

The problem is that you are comparing Editor's tabs with the explorer's tabs.
Editor's ones are wider so they look good with the current implementation ->
before it was very hard to find which one was selected.

But agree that explorer's ones are sometime hard to read. It just depends on
how wide a tab is. Wider -> better. I'll try your suggestions, thanks.

PS: better set TM to TBD since you can't know when it will be fixed ;) Can't be
for 5.5 anyway, since we cannot touch the core platform, only serious bug.
Comment 9 Martin Krauskopf 2006-09-12 09:58:38 UTC
I've applied your suggestion. We will see if there is somebody who have yet
another color-feeling ;)

Thanks for the "patch". Applied.

src/org/netbeans/swing/tabcontrol/plaf/WinClassicEditorTabCellRenderer.java;
new revision: 1.14; previous revision: 1.13
src/org/netbeans/swing/tabcontrol/plaf/WinClassicViewTabDisplayerUI.java;
new revision: 1.25; previous revision: 1.24
Comment 10 R Ramos 2006-09-13 08:47:15 UTC
I downloaded an tested it. Thanks. I think it looks better now. I had read some
user comments on the NBUI mailing list and also comments on my blog about the
GTK LaF and this topic. I hope people will be happy with the results.