This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 66404 - When platform-private.properties refers to nonexistent file, opening project should reset it
Summary: When platform-private.properties refers to nonexistent file, opening project ...
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P1 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
: 68353 (view as bug list)
Depends on:
Blocks: 65366
  Show dependency tree
 
Reported: 2005-10-10 16:36 UTC by _ pkuzel
Modified: 2005-11-29 14:41 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
hotfix (3.17 KB, patch)
2005-11-09 12:25 UTC, Martin Krauskopf
Details | Diff
hotfix_67892a (3.18 KB, patch)
2005-11-09 12:38 UTC, Martin Krauskopf
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description _ pkuzel 2005-10-10 16:36:18 UTC
Extract issue #65366 contribution under nb_all and ry to open IDE. Nothing happens.

Expected behaviour, it opens. It can ask some environment binding questions if
needed.
Comment 1 Jesse Glick 2005-10-10 20:20:08 UTC
There are two errors in the ZIP file attached.

1. It is a standalone project. If you want it under netbeans.org, it must be
made a netbeans.org project. Delete <standalone/> from project.xml, delete
build-impl.xml, platform.properties, genfiles.properties, and private/, and
modify build.xml to use projectized.xml.

2. The ZIP included nbproject/private/, which it should not have. (E.g. when
using projectpackager, it would not.) apisupport/project currently recovers from
such misconfiguration in case the problem is that platform.properties refers to
a nonexistent platform, but not yet in case nbplatform.active=default yet
platform-private.properties refers to a nonexistent file. Fixable but might not
be for 5.0.
Comment 2 Martin Krauskopf 2005-11-09 10:56:21 UTC
*** Issue 68353 has been marked as a duplicate of this issue. ***
Comment 3 pzajac 2005-11-09 11:03:07 UTC
It is beta showstopper. It is very disturbing for user who uses daily builds to
develop netbeans module (netcat, etc)
Comment 4 Martin Krauskopf 2005-11-09 12:25:23 UTC
Created attachment 26756 [details]
hotfix
Comment 5 Martin Krauskopf 2005-11-09 12:27:40 UTC
I've attached hotfix which reset user.properties.file for stand-alone module
like OpenProject hook does. Just quick and dirty solution.
Comment 6 Martin Krauskopf 2005-11-09 12:38:54 UTC
Created attachment 26757 [details]
hotfix_67892a
Comment 7 Martin Krauskopf 2005-11-09 12:39:48 UTC
Previous hotfix was too hot - didn't count with the case when
platform-private.properties doesn't exists.
Comment 8 Jesse Glick 2005-11-09 23:54:17 UTC
I'm working on it but it will take some time. I need to write extensive unit
tests for this - previously this area of the code was hardly tested at all - and
do several refactorings to consolidate the important logic. The final fix should
be an improvement (and a step towards a solution to issue #61227 when we can
push more things into the GUI), but will not be trivial and could introduce
regressions, so I do not plan to push this into the beta2 branch.

QA should feel free to test Martin's hotfix for the branch - looks harmless but
is just a band-aid over the lack of a full fix. Otherwise this could be left
open in the branch - it has been known for some time, and workaround should just
be to delete the nbproject/private/ dir of all NBM-related projects before
starting new IDE installation (perhaps). I don't know if issue #68353 and/or
issue #67892 are really duplicates of this issue exactly, as there are a number
of kinds of misconfigurations that may or may not be handled by the current code
- I just plan to write tests covering everything I can think of and close them
all when the tests pass.
Comment 9 Jesse Glick 2005-11-10 05:43:58 UTC
Prep work:

committed   * Up-To-Date  1.41       
apisupport/project/src/org/netbeans/modules/apisupport/project/NbModuleProjectGenerator.java
committed   * Up-To-Date  1.21       
apisupport/project/src/org/netbeans/modules/apisupport/project/layers/LayerUtils.java
committed   * Up-To-Date  1.24       
apisupport/project/src/org/netbeans/modules/apisupport/project/suite/SuiteProject.java
committed   * Up-To-Date  1.14       
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/ModuleActions.java
committed   * Up-To-Date  1.23       
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/SuiteProperties.java
committed   * Up-To-Date  1.2        
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/platform/PlatformComponentFactory.java
committed   * Up-To-Date  1.26       
apisupport/project/src/org/netbeans/modules/apisupport/project/universe/NbPlatform.java
added       * Up-To-Date  1.1        
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/BrokenPlatformReferenceTest.java
committed   * Up-To-Date  1.28       
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/NbModuleProjectTest.java
committed   * Up-To-Date  1.27       
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/TestBase.java
committed   * Up-To-Date  1.14       
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/universe/NbPlatformTest.java
Comment 10 Marian Mirilovic 2005-11-10 10:25:14 UTC
So, Martin'll commit the hot-fix to the Beta2 branch soon.
Comment 11 Martin Krauskopf 2005-11-10 14:38:14 UTC
As soon as my cvs update finished (currently trying so for more than one hour)
I'll implement the workaround, run commit validation and commit....
Comment 12 Martin Krauskopf 2005-11-10 15:40:34 UTC
Workaround commited into release50_beta2.

Checking in NbModuleProject.java; 1.125 -> 1.125.2.1;
Comment 13 Marian Mirilovic 2005-11-10 15:47:57 UTC
Hot-fix fro NB 5.0 Beta 2 tracked under issue 68474
Comment 14 Jesse Glick 2005-11-16 00:19:28 UTC
More to do, but this at least should be fixed now.

committed   * Up-To-Date  1.128      
apisupport/project/src/org/netbeans/modules/apisupport/project/NbModuleProject.java
committed   * Up-To-Date  1.24       
apisupport/project/src/org/netbeans/modules/apisupport/project/Util.java
committed   * Up-To-Date  1.3        
apisupport/project/src/org/netbeans/modules/apisupport/project/queries/SourceLevelQueryImpl.java
committed   * Up-To-Date  1.26       
apisupport/project/src/org/netbeans/modules/apisupport/project/suite/SuiteProject.java
committed   * Up-To-Date  1.2        
apisupport/project/src/org/netbeans/modules/apisupport/project/suite/SuiteSubprojectProviderImpl.java
committed   * Up-To-Date  1.21       
apisupport/project/src/org/netbeans/modules/apisupport/project/universe/ModuleList.java
committed   * Up-To-Date  1.3        
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/BrokenPlatformReferenceTest.java
committed   * Up-To-Date  1.29       
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/NbModuleProjectTest.java
committed   * Up-To-Date  1.23       
apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/queries/ClassPathProviderImplTest.java
Comment 15 pzajac 2005-11-29 14:41:33 UTC
works fine for standalone and module suite projects