This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 64968 - Include core/favorites in platform cluster
Summary: Include core/favorites in platform cluster
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Favorites (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2005-09-23 09:55 UTC by Jaroslav Tulach
Modified: 2008-12-22 19:35 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
This is the patch I'd like to apply (13.33 KB, patch)
2005-09-27 14:14 UTC, Jaroslav Tulach
Details | Diff
Changes including correct deps for projectui (22.24 KB, patch)
2005-09-29 12:53 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2005-09-23 09:55:06 UTC
Discussion in issue 62989 resulted into an opinion that it can be useful and 
does not do any harm if we move core/favorites to platform cluster. 
 
VOC: "in an application built on top of 3.4 we used loaders and templates. it 
was the heart of the application built on top of soap filesystem. it 
definitely could have been done otherwise but it saved a lot of time I think 
to reuse these APIs." 
 
CTQ: "let's have the initial look of a suite using just platform as empty as 
possible, make it easy for people writing non-file/loader based applications, 
make it easy for people wishing to use loader to use them." 
 
Solution: "let's move core/favorites to platform, make them disabled by 
default(we already disable autoupdate, so no problem with that) and let them 
contain the template  manager. This satisfies or get as much closer to the 
CTQ."
Comment 1 Jaroslav Tulach 2005-09-23 09:57:24 UTC
I am ready to move the module if we agree on the VOC, CTQ and solution. 
Anybody seeing this change as a blocker please speak up. 
Comment 2 Jesse Glick 2005-09-23 17:00:04 UTC
Should probably attach patch: to nbbuild/cluster.properties; possibly to
nbbuild/build.properties; and to
apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/SuiteCustomizerModuleList.java
and apisupport/www/phase-V-ui.html (for the default exclusion).
Comment 3 mslama 2005-09-23 18:17:23 UTC
Q: It is not clear to me how is core/favorites connected to presence of loaders
or  template manager. 
Comment 4 Jesse Glick 2005-09-23 18:28:35 UTC
Template Manager was moved to core/favorites, I think.
Comment 5 mslama 2005-09-23 18:30:48 UTC
Yes you are right. Thanks.
Comment 6 Jaroslav Tulach 2005-09-24 12:23:30 UTC
> > Url: 
> > http://core.netbeans.org/source/browse/core/ui/src/org/netbeans/core/ui/r 
> >esources/layer.xml?r1=1.102&r2=1.103 <attr name="simple" boolvalue="false" 
> > /> 
> >         <file name="Folder.shadow"> 
> > -                <attr name="originalFile" 
> > stringvalue="Templates/Other/Folder"/> +                <attr 
> > name="originalFile" stringvalue="Templates/Folder"/> </file> 
> >     </folder> 
> 
> Hele, shouldn't these "templates" be in core/favorites rather than 
> core/ui, since that is where the other template-related stuff seems to 
> get put now? 
 
I guess you are right, I'll prepare this together with a patch for  
http://www.netbeans.org/issues/show_bug.cgi?id=64968 
 
Comment 7 Jaroslav Tulach 2005-09-27 14:14:46 UTC
Created attachment 25224 [details]
This is the patch I'd like to apply
Comment 8 Jesse Glick 2005-09-27 17:29:50 UTC
1. build.properties probably needs patching

2. projects/projectui/nbproject/project.xml still depends on
org.netbeans.core.ui, I guess to mask the Folder template (?), so if this dep is
kept it should be switched to org.netbeans.modules.favorites
Comment 9 Jaroslav Tulach 2005-09-29 12:48:26 UTC
build.properties is (imho) only useful for list of modules to build javadoc. 
And favorites do not have javadoc. I do not know why or what shall I change 
there. 
 
projectui module overrides Explorer.wsmode and Folder template. So the deps on  
core/favorites and core/ui need to be there. 
 
I'll attach updated patch. 
Comment 10 Jaroslav Tulach 2005-09-29 12:53:29 UTC
Created attachment 25295 [details]
Changes including correct deps for projectui
Comment 11 Jesse Glick 2005-09-29 16:55:50 UTC
Well, build.properties does include config.{,fixed}modules.platform, which until
now listed all the modules in the platform cluster. If this moduleconfig is not
used for anything, which may be the case, then I will delete it.
Comment 12 Jaroslav Tulach 2005-10-03 13:14:05 UTC
If there are no objections I'd like to apply the patch tomorrow. I do not plan 
to update build.properties as the only important config there I know (javadoc) 
is not affected by this change. 
Comment 13 Jesse Glick 2005-10-03 17:03:30 UTC
Update: you must patch build.properties#platform to include core/favorites. Also
please run build.xml#check-module-configs (which should fail if build.properties
is not patched) and commit updated ide/golden/moduleconfigs.txt accordingly.
Comment 14 Jaroslav Tulach 2005-10-05 17:55:51 UTC
Integrated yesterday. 
 
http://core.netbeans.org/servlets/ReadMsg?list=cvs&msgNo=12867