This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
The behavior of the BrokenReferenceModel and ReferenceSupport was changed to improve the shareability. By this change projects are using relative paths if possible, not possible when the referenced resources are on the different disks on Windows. This API change does not influence the signatures but it influences the behavior of the ReferenceSupport and BrokenReferencesModel.
Created attachment 24319 [details] Diff file
Created attachment 24363 [details] CHanged diff of ReferenceHelper, the relativization to external base dirs has precedence, the rest of original diff is unchanged
Created attachment 24375 [details] New complete diff
apichanges.xml: typo "collocalted"; also is "ReferenceHelper.addReference" a descriptive (and unique) ID?; and don't forget <issue>. Doesn't ARCQ supersede PCCQ? I.e. there is no case where PCCQ would return true where ARCQ would not also return true. In that case PCCQ can simply be deleted. Tip: for for (int i=0; i<roots.length; i++) { if (roots[i].equals(f)) { return true; } } return false; just write return Arrays.asList(roots).contains(f); I don't see anything wrong with the patch as such, so I guess it is mainly about carefully testing each known scenario in a real IDE build and making sure the behavior is sane.
Agreed, the patch looks OK, but it should be tested carefully.
I agree with the proposed change.
I agree, I don't see any problems for web, ejbjar and ear project types.
Checking in ant/project/apichanges.xml; /cvs/ant/project/apichanges.xml,v <-- apichanges.xml new revision: 1.9; previous revision: 1.8 done Checking in ant/project/manifest.mf; /cvs/ant/project/manifest.mf,v <-- manifest.mf new revision: 1.13; previous revision: 1.12 done Checking in ant/project/src/org/netbeans/spi/project/support/ant/ReferenceHelper.java; /cvs/ant/project/src/org/netbeans/spi/project/support/ant/ReferenceHelper.java,v <-- ReferenceHelper.java new revision: 1.28; previous revision: 1.27 done Checking in ant/project/test/unit/src/org/netbeans/spi/project/support/ant/ReferenceHelperTest.java; /cvs/ant/project/test/unit/src/org/netbeans/spi/project/support/ant/ReferenceHelperTest.java,v <-- ReferenceHelperTest.java new revision: 1.20; previous revision: 1.19 done Checking in projects/queries/src/META-INF/services/org.netbeans.spi.queries.CollocationQueryImplementation; /cvs/projects/queries/src/META-INF/services/org.netbeans.spi.queries.CollocationQueryImplementation,v <-- org.netbeans.spi.queries.CollocationQueryImplementation new revision: 1.5; previous revision: 1.4 done RCS file: /cvs/projects/queries/src/org/netbeans/modules/queries/AlwaysRelativeCollocationQuery.java,v done Checking in projects/queries/src/org/netbeans/modules/queries/AlwaysRelativeCollocationQuery.java; /cvs/projects/queries/src/org/netbeans/modules/queries/AlwaysRelativeCollocationQuery.java,v <-- AlwaysRelativeCollocationQuery.java initial revision: 1.1 done RCS file: /cvs/projects/queries/test/unit/src/org/netbeans/modules/queries/AlwaysRelativeCollocationQueryTest.java,v done Checking in projects/queries/test/unit/src/org/netbeans/modules/queries/AlwaysRelativeCollocationQueryTest.java; /cvs/projects/queries/test/unit/src/org/netbeans/modules/queries/AlwaysRelativeCollocationQueryTest.java,v <-- AlwaysRelativeCollocationQueryTest.java initial revision: 1.1 done Checking in java/project/apichanges.xml; /cvs/java/project/apichanges.xml,v <-- apichanges.xml new revision: 1.12; previous revision: 1.11 done Checking in java/project/manifest.mf; /cvs/java/project/manifest.mf,v <-- manifest.mf new revision: 1.15; previous revision: 1.14 done Checking in java/project/src/org/netbeans/modules/java/project/BrokenReferencesModel.java; /cvs/java/project/src/org/netbeans/modules/java/project/BrokenReferencesModel.java,v <-- BrokenReferencesModel.java new revision: 1.19; previous revision: 1.18 done
Marking this issue as VERIFIED since the issue reporter == issue owner.