This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 62569 - Check proper completion locking
Summary: Check proper completion locking
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@editor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-18 12:11 UTC by Miloslav Metelka
Modified: 2007-11-05 13:44 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miloslav Metelka 2005-08-18 12:11:09 UTC
Re-check the proper order of the completion and document locking. This follows
fixing of issue 61997.
Comment 1 Miloslav Metelka 2005-09-15 10:31:16 UTC
The CompletionImpl lock is now only used internally and the methods of SPI
classes are no longer invoked under that lock. This should help to avoid
potential deadlocks.
There was a missing stopping of both the completion and documentation timer when
hideCompletion() and hideDocumentation() is called. It's now fixed.
Another fix is that the editor warmup had incorrectly set document of warmup
editor pane outside of the AWT thread.
Fixed in trunk:
Checking in
editor/completion/src/org/netbeans/api/editor/completion/Completion.java;
/cvs/editor/completion/src/org/netbeans/api/editor/completion/Completion.java,v
 <--  Completion.java
new revision: 1.3; previous revision: 1.2
done
Checking in
editor/completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java;
/cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java,v
 <--  CompletionImpl.java
new revision: 1.11; previous revision: 1.10
done
RCS file:
/cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionItemComparator.java,v
done
Checking in
editor/completion/src/org/netbeans/modules/editor/completion/CompletionItemComparator.java;
/cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionItemComparator.java,v
 <--  CompletionItemComparator.java
initial revision: 1.1
done
Checking in
editor/completion/src/org/netbeans/modules/editor/completion/CompletionResultSetImpl.java;
/cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionResultSetImpl.java,v
 <--  CompletionResultSetImpl.java
new revision: 1.4; previous revision: 1.3
done
Checking in
editor/completion/src/org/netbeans/spi/editor/completion/CompletionTask.java;
/cvs/editor/completion/src/org/netbeans/spi/editor/completion/CompletionTask.java,v
 <--  CompletionTask.java
new revision: 1.4; previous revision: 1.3
done
Checking in
java/editor/src/org/netbeans/modules/java/editor/JavaEditorWarmUpTask.java;
/cvs/java/editor/src/org/netbeans/modules/java/editor/JavaEditorWarmUpTask.java,v
 <--  JavaEditorWarmUpTask.java
new revision: 1.3; previous revision: 1.2