This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 5970 - Customize Bean dialog off an External Executor node - if you edit BootClassPath and then click cancel, changes are made anyway.
Summary: Customize Bean dialog off an External Executor node - if you edit BootClassPa...
Status: CLOSED DUPLICATE of bug 20369
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: All All
: P4 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-03-12 00:11 UTC by _ tboudreau
Modified: 2008-12-23 11:38 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2000-03-12 00:11:24 UTC
I set Boot Class Path to "" and closed the dialog (windows style or cancel)
My change persisted.  This shouldn`t happen; after all, I selected cancel.

The change was only local to `CMD Java` (good job), but the cancel button should not be storing changes, it should revert to the values from before the dialog loaded (or be called "OK").

For completeness, I clicked help:
If you do not want to keep the customized settings, press the Cancel button to close the
customization window.

The behavior is inconsistent with the help.

[jglick] This is difficult to fix IMHO: normally Customize Bean is used on .java/.ser files which means you create an instance, customize, then maybe serialize back. In that situation Cancel is obviou
s. But a live Bean such as an Executor is simply changed when you change its property sheet, and Cancel does nothing to reverse the change; it can`t. Also the InstanceCookie which drives all this does
 not specify any particular way to clone the Bean, write changes back, etc. And there is no Bean Spec standard way of doing this anyway, except serializing and deserializing to clone if not Cloneable;
 writing changes back is not generally possible for non-Externalizable objects, if you want to keep object identity, i.e. you can only irreversibly change the original Bean or create a new Bean with t
he changes. Basically the architecture does not provide any good way to fix this bug. InstanceCookie may need to be rethought; InstanceCookie.Origin is almost certainly much too specific to be useful
generally; some explicit description of whether the Bean should be cloned, and how to save or reverse changes is necessary. Also see other S.T. suggestions (by me) re. general ideas for InstanceCookie

 + CustomizeBeanAction; and re. general notion of Cancel button for property sheet. Probably neither of these are good ideas but may be helpful to look at.
Comment 1 Marek Grummich 2000-07-25 09:23:59 UTC
Priority is changed to P4 (normal).
Comment 2 Jaroslav Tulach 2002-02-19 16:40:50 UTC
Reopening to close.
Comment 3 Jaroslav Tulach 2002-02-19 16:41:32 UTC
Closing. Tim if you think we should still fix it, reopen it.
Comment 4 _ tboudreau 2002-02-20 09:48:50 UTC
Sorry, this *is* a bug.  If I open a dialog where I can edit
something, and there is a button that says "Cancel", that means "throw
away my changes, I didn't really want to do that."  

However, there is a simple fix:  Change "Cancel" to "Close."

But the bigger question:
When on earth is it useful to be able to make a serialized copy of an
execution service internal to the IDE?  All of the properties in this
dialog are also available on the execution service's property sheet. 
The only thing this dialog adds is the serialize option.  I think
probably the only case where someone would invoke it is by mistake. 
What about simply supressing the "customize" menu item?  That would
also solve the problem.
Comment 5 Marian Mirilovic 2002-02-20 10:31:15 UTC
Tim, it seems like its fixed now in [nb_dev](20020220).

Closing as duplicate of issue 20369

*** This issue has been marked as a duplicate of 20369 ***
Comment 6 Quality Engineering 2003-07-02 16:49:14 UTC
Resolved for 3.4.x or earlier, no new info since then -> verify
Comment 7 Quality Engineering 2003-07-02 17:19:10 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.