This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 58882 - Use new progress UI component for the progress indication of help opening
Summary: Use new progress UI component for the progress indication of help opening
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Help System (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: mslama
URL:
Keywords:
Depends on: 60966
Blocks:
  Show dependency tree
 
Reported: 2005-05-13 16:45 UTC by Antonin Nebuzelsky
Modified: 2008-12-22 15:56 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Diff of patch (8.55 KB, text/plain)
2005-08-02 16:20 UTC, mslama 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2005-05-13 16:45:29 UTC 
First opening of help takes some time and an ungly small window is displayed
with a progress indication.

New progress UI/API should be used for the help opening progress indication, if
possible.
Comment 1 Antonin Nebuzelsky 2005-07-28 15:55:03 UTC 
Performance team decided to change those tasks, which describe already existing
progress bars in the IDE, to defects. These, if not fixed, would cause UI
inconsistency with those which are already migrated to the new progress UI.

This should be fixed before promo-F feature freeze.
Comment 2 mslama 2005-07-29 15:39:55 UTC 
I checked and yes current progress dialog is created by core-javahelp module =>
it is possible to overwrite it to use new API.
Comment 3 Antonin Nebuzelsky 2005-07-29 15:42:18 UTC 
That's great. The current progress dialog is very ugly.
Comment 4 mslama 2005-08-02 16:08:35 UTC 
I used Progress API in modal dialog. However with current value of INITIAL_DELAY
it looks bad as progress component is displayed too late. When loading helpsets
is faster progress component is not displayed at all in dialog. It looks much
better when I tried to lower INITIAL_DELAY. I added dependency on #60966 so that
I am able to change INITIAL_DELAY for given task to get better result. I suggest
to fix this issue after #60966 is fixed.

I will attach diff here.
Comment 5 mslama 2005-08-02 16:20:39 UTC 
Created attachment 23427 [details]
Diff of patch
Comment 6 mslama 2005-08-02 16:25:42 UTC 
Fix creates modal dialog with the same title as before. Inside dialog there is
only progress component with following changes:
1.Its preferred size is 3 times bigger so it is not too small.
2.I added empty 10pts border around progress component.

If necessary I can polish UI. Is it necessary to pass UI review with this
change? Who can decide it? At least someone should check current UI. Problem is
I cannot commit this change before issue #60966 is somehow fixed as without this
new progress looks bad as usually it shows only for short time < 1s.
Comment 7 Antonin Nebuzelsky 2005-08-29 11:29:45 UTC 
Marku, I have tried your patch. Looks good, though the timing is not good. I
think you should commit the change before FF and Milos will fix his issue after
he gets back from vacation. His issue is a regular defect so it should not be
problem to fix after FF.
Comment 8 mslama 2005-08-31 09:20:30 UTC 
I was asked to commit this fix even if issue #60966 is not fixed yet.

Modified:
/cvs/ide/golden/deps.txt
new revision: 1.188; previous revision: 1.187

/cvs/core/javahelp/nbproject/project.xml
new revision: 1.8; previous revision: 1.7

/cvs/core/javahelp/src/org/netbeans/modules/javahelp/Bundle.properties
new revision: 1.8; previous revision: 1.7

/cvs/core/javahelp/src/org/netbeans/modules/javahelp/JavaHelp.java
new revision: 1.30; previous revision: 1.29
Comment 9 Marian Mirilovic 2005-10-26 10:49:20 UTC 
verified in NB5.0(200510251800)