This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57949 - Deploy Dialog not closed
Summary: Deploy Dialog not closed
Status: RESOLVED WONTFIX
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 4.x
Hardware: All All
: P4 blocker (vote)
Assignee: Sherold Dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-15 16:33 UTC by Ivan Sidorkin
Modified: 2005-09-05 10:01 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Sidorkin 2005-04-15 16:33:48 UTC
Deployment window not closed after receiving Event with status "COMPLETED"
Comment 1 _ ludo 2005-04-15 17:29:06 UTC
And why is this a P1?
Come on..Read the bug priorities guidelines. Is it blocking you in any way?
Can you tell us if the deployment was ok?
Also, I cannot reproduce it with my build...
Indicate the complete steps to reproduce, as well as which version, which jdk
verison, which app server version etc.
Comment 2 Ivan Sidorkin 2005-04-15 17:36:50 UTC
Yes, it blocking me in JBoss plugin development in Buzz.
I cant close deployment process window afte sucsess deploy, 
so in 2 minutes deployment fails.
Comment 3 _ ludo 2005-04-15 17:46:33 UTC
Ha, now we talk!

So maybe the issue in on the jboss plugin, because it's working fine for AS 8.1
and Tomcat...
I guess some event from progress bar is not correctly fired on the jboss side...
Can you take a look at how the tomcat plugin communicates via jsr88 progress
object and see which event you are missing maybe?
org.netbeans.modules.tomcat5.progress.ProgressEventSupport
in the tomcat5 area.
Comment 4 Nam Nguyen 2005-04-15 19:23:29 UTC
Ivan, since this works for other plugins.  I suggest that you make sure that the
event COMPLETE is fired on the same ProgressOjbect that you return from
DM.distribute or DM.redeploy or DM.start calls.  Having making sure that, the
other possibility for the difference might be very hard to track timing bug. 
Try introduce some delay before firing the COMPLETE event..

Comment 5 Sherold Dev 2005-04-18 17:01:50 UTC
Ivan, the "COMPLETED" status event is not enought for the progress dialog to be
closed. The progress dialog can be reused for more than one "deployment
operation", e.g. when you run deploy in IDE

DeploymentManager.distribute()
DeploymentManager.start()

methods will be called and both will be handled with the same progress dialog.

The issue will be most likely on the plugin side, sice it works for both Tomcat
and AppServer.

You should check whether you ever get to line #148 of the 
org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment class when
running deploy. 

148 >                progress.recordWork(MAX_DEPLOY_PROGRESS);

It is this line who is responsible for closing the progress dialog.

One tip, I've tried to debug deploying on JBoss shortly and found out that your
progress object getResultTargetModuleIDs() method returns empty array. See the
line #685 of the org.netbeans.modules.j2ee.deployment.impl.TargetServer class

685 >        TargetModuleID[] modules = po.getResultTargetModuleIDs();

Try to fix this and lets see if it gets better.
Comment 6 Sherold Dev 2005-08-16 18:00:59 UTC
Closing as WONTFIX, since the progress dialog has been replaced by the new
global progress indication.