This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Just noticed that www/www/updates/41beta_1.9_.xml has numerous XML validation errors according to its DTD; seems it is more error than not! For that matter, I cannot find a single XML file in this dir which *does* validate without errors. It is unacceptable to publish *any file* in www/www/updates/**/*.xml which fails XML validation; any violation should be treated as a P2 defect to be corrected before publishing a release, either manually or by fixing the tools which generated malformed content. (And the tools which create these files should do a sanity validation before exiting and report an error if the validation fails.) The DTDs exist for a reason. They specify what the autoupdate client in a given IDE build is prepared to accept from the server. If it is given malformed input, its behavior is not likely to be good. (Ideally it would reject invalid input immediately so that the problem never progresses this far.)
I'll take care of this issue. Tools that generate UC catalogs stored in www/www/updates/**/*.xml need to be enhanced to produce XML files that do validate without errors. Following enhancements need to be done: 1. Catalogs are generated from modules NBMs, therefore info.xml files need to be validated before they are used for catalog generating and NBMs with invalid info.xml should be rejected. 2. Catalogs have to be generated according to the DTD version valid for target NB release. Right now DTD have to be set manually that is confusing. 3. Catalogs should be validated before they are uploaded to the UC
will be fixed for promo G
Roberte, what's status of this issue?
Probably dupe of issue #37376 (or vice versa).
Is this still valid?
Yes this is still valid. Picking the first XML file I saw at random, 60m10_1.22_.xml, and validating: XML validation started. Checking file:/space/src/nb_all/www/www/updates/60m10_1.22_.xml... Referenced entity at "http://www.netbeans.org/dtds/autoupdate-catalog-2_5.dtd". Document root element "module_updates", must match DOCTYPE root "autoupdate_catalog". [6] Element type "feature" must be declared. [8] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [11] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [15] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [19] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [23] Element type "feature" must be declared. [26] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [29] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [33] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [37] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [41] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [45] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [49] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [53] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [57] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [61] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [65] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [69] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [73] Attribute "OpenIDE-Module-Build-Version" must be declared for element type "manifest". [137] Too many errors, stopping further checking. XML validation finished.
I think we should ensure that new catalogs satisfy the validation now! Robert, you should do something with this open P2 now. Can you fix it for new catalogs?
I'm taking care of it and making it my top priority.
catalog.xml is failing to validate, because some of modules contain manifest attributes: OpenIDE-Module-Friends or OpenIDE-Module-Build-Version Jirka, any suggestions ? Can wee add these attributes to the catalog DTD ?
OpenIDE-Module-Friends and OpenIDE-Module-Friends are not needed in the catalog DTD. They are manifest attributes which are irrelevant to AU and should not be generated in Info.xml or catalogs.
Ah, I see. But it means, that info.xml for these modules can not be validated neither against its DTD. Attributes like OpenIDE-Module-Friends or OpenIDE-Module-Friends should not appear in info.xml neither. I will fix my tool for generating of UC catalogs from modules NBMs to include only allowed attributes. But I suggest to fix also task that generates module info.xml file.
I'm not sure I understand the last comment. I just ran ant -f ant/freeform/build.xml nbm in trunk sources and inspected the generated Info/info.xml. It was valid acc. to DTD, and had no OpenIDE-Module-Friends attribute in <manifest>.
Fixed for NB 6.0 Beta2 (and further) Update Centers.