This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57556 - j2ee/utilities friends API change (cleanup) review
Summary: j2ee/utilities friends API change (cleanup) review
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: apireviews
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2005-04-06 17:05 UTC by Marek Fukala
Modified: 2005-09-05 10:01 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
The commit log (52.07 KB, text/plain)
2005-04-15 15:14 UTC, Marek Fukala
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Fukala 2005-04-06 17:05:53 UTC
We realized that the majority of the API's classes is used only by one client
and hence there is no need to have such classes in an api.

Biggest part of the api's code should be moved to the ear project and part to
ejb project. After removing this "one client" classes the rest looks as follows:

org.netbeans.modules.j2ee.common
 - Util.java
org.netbeans.modules.j2ee.common.ui
 - ServerResourceNode.java
org.netbeans.modules.j2ee.common.ui.nodes
 [without change - the code is used by more modules]

Such a simplified api is used from j2ee/earproject, j2ee/ejbjarproject,
web/project and websvc/core modules from enterprise1 cluster.

See also related Issue #54479.
Comment 1 Pavel Buzek 2005-04-08 15:36:00 UTC
This is a good step is solving 54479. +1 from me.
Comment 2 Marek Fukala 2005-04-15 15:13:04 UTC
fixed in trunk
Comment 3 Marek Fukala 2005-04-15 15:14:00 UTC
Created attachment 21679 [details]
The commit log
Comment 4 Nikolay Molchanov 2005-04-16 21:45:12 UTC
Unfortunately there is a minor problem with the latest fix for this issue.
Last line in file Bundle.properties was added without linefeed. 

bash-2.05$ cd j2ee/utilities/src/org/netbeans/modules/j2ee/common
bash-2.05$ tail -1 Bundle.properties
OpenIDE-Module-Short-Description=Utilities for J2EE projectsbash-2.05$

We have automated process, that integrates changes from CVS repository 
to TeamWare workspaces (where files are under SCCS control), and SCCS 
utilities treat file as "binary", if there is no linefeed at the end 
of file. So, originally file Bundle.properties was checked in as "text",
and now 'sccs delta' cannot update file, because it cannot change type
of file. We can find a workaround, but the easiest way is to fix this
problem in CVS repository.

Please, add linefeed to the end of file Bundle.properties (or let me know
if this is undesired or impossible, and I'll implement a workaround).

Thanks in advance,
Nikolay Molchanov (Nikolay.Molchanov@sun.com)
Comment 5 Marek Fukala 2005-04-18 07:50:17 UTC
added the new line

Checking in Bundle.properties;
/cvs/j2ee/utilities/src/org/netbeans/modules/j2ee/common/Bundle.properties,v 
<--  Bundle.properties
new revision: 1.7; previous revision: 1.6
done