This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 56709 - Last Changes in LoggingRepaintManager causes regression on complex startup
Summary: Last Changes in LoggingRepaintManager causes regression on complex startup
Status: CLOSED FIXED
Alias: None
Product: qa
Classification: Unclassified
Component: Tests (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: issues@performance
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-21 09:00 UTC by Marian Mirilovic
Modified: 2011-05-24 13:39 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Mirilovic 2005-03-21 09:00:20 UTC
NB4.1(200503201900), JDK1.5.0_02

We have measured huge regression on Complex startup ...

I've found out that it works fine with 
performance-test-utilities.jar revision 1.8 
but it doesn't work with
performance-test-utilities.jar revision 1.9

and I think root of these problems is Martin's commit:
------
User: mschovanek
Date: 05/03/18 06:55:07

Modified:
 /performance/performancetestutilities/dist/
  performance-test-utilities.jar

Log:
 changed lastPaint handling, event filtering, ...
----------
Comment 1 Marian Mirilovic 2005-03-21 09:30:21 UTC
I found it , the problem is in next change  in LoggingRepaintManager.java
    public void paintDirtyRegions() {
        super.paintDirtyRegions();
        lastPaint = System.currentTimeMillis(); // !!!!!! actual place of this
line - this caused problems
        if (tr != null && hasDirtyMatches) {
        lastPaint = System.currentTimeMillis(); // !!!!!! previous place of this
line - this caused problems
            tr.add(tr.TRACK_PAINT, "Done painting");
            hasDirtyMatches = false;
        }
    }
-----------------


Martin, why did you change this ? 

... and additional info : you have changed also 
------------
    /** Creates a new instance of LoggingRepaintManager */
    public LoggingRepaintManager(ActionTracker tr) {
        this.tr = tr;
        lastPaint = System.currentTimeMillis(); // !!!!! this is new code 
    }
------------
Why ? 

Do you have any objection to reverting these changes ?

Comment 2 Marian Mirilovic 2005-03-21 12:48:41 UTC
We are catching cursor blinking during Complex startup time measurement ...
Comment 3 Marian Mirilovic 2005-03-22 15:13:17 UTC
I haven't found better solution, just move the lastPaint initialization at the
previous place.....
Sorry ;(

cvs commit -m "move lastPaint initialization at the previous place - issue
56709, replace waitNoEvent by waitNoPaintEvent because the original one is
misleading" performancetestutilities/dist/performance-test-utilities.jar
performancetestutilities/src/org/netbeans/performance/test/guitracker/LoggingRepaintManager.java
performancetestutilities/src/org/netbeans/performance/test/utilities/PerformanceTestCase.java
Checking in performancetestutilities/dist/performance-test-utilities.jar;
/cvs/performance/performancetestutilities/dist/performance-test-utilities.jar,v
 <--  performance-test-utilities.jar
new revision: 1.12; previous revision: 1.11
done
Checking in
performancetestutilities/src/org/netbeans/performance/test/guitracker/LoggingRepaintManager.java;
/cvs/performance/performancetestutilities/src/org/netbeans/performance/test/guitracker/LoggingRepaintManager.java,v
 <--  LoggingRepaintManager.java
new revision: 1.7; previous revision: 1.6
done
Checking in
performancetestutilities/src/org/netbeans/performance/test/utilities/PerformanceTestCase.java;/cvs/performance/performancetestutilities/src/org/netbeans/performance/test/utilities/PerformanceTestCase.java,v
 <--  PerformanceTestCase.java
new revision: 1.8; previous revision: 1.7
done
Comment 4 Marian Mirilovic 2005-03-25 13:39:50 UTC
verified, it works fine now....