This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 56308 - clean up app server packaging
Summary: clean up app server packaging
Status: CLOSED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 8 (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: _ ludo
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2005-03-12 01:26 UTC by _ ludo
Modified: 2006-03-24 13:08 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ ludo 2005-03-12 01:26:42 UTC
For historical reasons (licences, time,...) the delivery of the app server 8,1
plugin was as one scrambled nbm in the netbeans repository.
In November last year, we decided to split our monolitical plugin in 2 pieces:

1/ one very similar to the ejb dd api module, but for the Sun specifid DD files
(sun-*.xml)

2/ then the plugin

While we have 2 netbeans module in our close source repository, we implemented
the change by having a direct dependancy in the plugin manifest to the second
jar as a class-path entry.
So in essence, the sun dd api module is not seen as a netbeans module, but lives
in modules/ext/org-netbeans-modules-j2ee-sun-dd.jar

Jess Glick sent me a note about this last year, and of course I forget...

Now that I am finishing the arc case and the file layout structure, I remembered
this anomality.

So I would prefer to do this:
1/ expose the org-netbeans-modules-j2ee-sun-dd.jar as s regular netbeans module
2/ change our plugin module to have a dependancy with this new module, and
remove the class-path manifest entry
3/ update the golden files to expose this change, because of a new dep, and a
changed file layout where
modules/ext/org-netbeans-modules-j2ee-sun-dd.jar
would move to
modules/org-netbeans-modules-j2ee-sun-dd.jar

So this is a request to do that for 4.1.
I did talk to Pavel Buzek about that, and he was ok, as long as it is approved
via a fast review. So here we go.
Comment 1 Jaroslav Tulach 2005-03-15 08:59:21 UTC
Removal of jars from ext always seemed to me like a good thing to do. I think
this is a desirable change.
Comment 2 _ ludo 2005-03-16 06:16:59 UTC
Good.
So I am reading this as an approval.
Comment 3 Pavel Buzek 2005-03-16 20:41:55 UTC
agreement from two reviewers is an approval -- go ahead and integrate :-)
Comment 4 _ ludo 2005-03-18 03:42:41 UTC
almost there.
Commit validation test, re-test, re-test is killing me...Each time, at least 3
minutes wasted.
We really need to improve this, I don;t know how...

Comment 5 _ ludo 2005-03-18 05:45:39 UTC
integrated now.
Comment 6 Lukas Jungmann 2005-07-12 16:15:23 UTC
v.