This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 56127 - API review ow ActionsUtil.antIncludesList() method
Summary: API review ow ActionsUtil.antIncludesList() method
Status: CLOSED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Ant Project (show other bugs)
Version: 4.x
Hardware: PC All
: P3 blocker (vote)
Assignee: Tomas Zezula
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 51132
  Show dependency tree
 
Reported: 2005-03-10 10:29 UTC by Tomas Zezula
Modified: 2006-03-24 12:50 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Diff file (5.81 KB, patch)
2005-03-10 10:33 UTC, Tomas Zezula 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zezula 2005-03-10 10:29:59 UTC 
Change:
The current ActionUtils.antIncludeList (FileObject[] files, FileObject dir)
generates a recursive include list for directories. The API change introduces
new ActionUtils.antIncludeList (FileObject[] files, FileObject dir, boolean
recursive) which generates either recursive or non recursive include depending
on the value of the recursive parameter.
The old method is bridged into the new one.

Use case:
The compile single on the package should compile only the package (non recursive
 include) but the compile single on the folder (files view/tree view) should
compile the subtree (recursive include).
See: http://www.netbeans.org/issues/show_bug.cgi?id=51132

API Stability:
Should be part of the stable API
Both the old one and the new method are covered by test.
Comment 1 Tomas Zezula 2005-03-10 10:33:37 UTC 
Created attachment 20736 [details]
Diff file
Comment 2 Tomas Zezula 2005-03-21 13:39:46 UTC 
I am going to integrate it tomorrow.
Comment 3 Tomas Zezula 2005-03-22 07:59:34 UTC 
Checking in src/org/apache/tools/ant/module/api/support/ActionUtils.java;
/cvs/ant/src/org/apache/tools/ant/module/api/support/ActionUtils.java,v  <-- 
ActionUtils.java
new revision: 1.10; previous revision: 1.9
done
Checking in
test/unit/src/org/apache/tools/ant/module/api/support/ActionUtilsTest.java;
/cvs/ant/test/unit/src/org/apache/tools/ant/module/api/support/ActionUtilsTest.java,v
 <--  ActionUtilsTest.java
new revision: 1.7; previous revision: 1.6
done
Comment 4 Tomas Zezula 2005-03-22 09:48:47 UTC 
Checking in manifest.mf;
/cvs/ant/manifest.mf,v  <--  manifest.mf
new revision: 1.74; previous revision: 1.73
done
Checking in api/doc/changes/apichanges.xml;
/cvs/ant/api/doc/changes/apichanges.xml,v  <--  apichanges.xml
new revision: 1.16; previous revision: 1.15
done
Checking in src/org/apache/tools/ant/module/api/support/ActionUtils.java;
/cvs/ant/src/org/apache/tools/ant/module/api/support/ActionUtils.java,v  <-- 
ActionUtils.java
new revision: 1.11; previous revision: 1.10
done
Comment 5 Jaromir Uhrik 2005-07-14 16:20:22 UTC 
Verified.