This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 55132 - I18N - Check and fix I18N in editor module
Summary: I18N - Check and fix I18N in editor module
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 4.x
Hardware: PC Windows ME/2000
: P3 blocker (vote)
Assignee: issues@editor
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2005-02-17 12:54 UTC by Jan Becicka
Modified: 2007-11-05 13:44 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Diff of l10n.list changes for editor and html modules (1.00 KB, patch)
2005-04-04 17:17 UTC, Miloslav Metelka
Details | Diff
Diff of missing NOI18N in editor, html/editor and java/editor (44.08 KB, patch)
2005-04-04 20:17 UTC, Miloslav Metelka
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Becicka 2005-02-17 12:54:36 UTC
Module editor is not properly internationalized.
Please review source code to make sure that all
messages/labels will indeed come from the
localized bundle file.
If the value is not localizable, you shoul mark it
with //NOI18N

You can use nbbuild/misc/i18ncheck.pl script for
chcecking i18n. This script can be also used for
adding //NOI18N comments

All lozalized stuff (Bundles) must be listed in
"l10n.list" file.

Please also check and remove unused keys in your
Bundle.properties files. bundlecheck.pl script can
help you.

This issue must be fixed for promo-F.

Thanks
Comment 1 Miloslav Metelka 2005-04-04 17:11:38 UTC
I've checked that there should not be any unlocalized strings in the editor and
java/editor and html/editor.
However editor/l10n.list and html/l10n.list need to be updated both in trunk and
release41 branch.
Will attach diff. Another diff for missing "// NOI18N"
Comment 2 Miloslav Metelka 2005-04-04 17:17:58 UTC
Created attachment 21359 [details]
Diff of l10n.list changes for editor and html modules
Comment 3 Miloslav Metelka 2005-04-04 17:38:12 UTC
Integrated the diff into trunk:
Checking in editor/l10n.list;
/cvs/editor/l10n.list,v  <--  l10n.list
new revision: 1.7; previous revision: 1.6
done
Checking in html/l10n.list;
/cvs/html/l10n.list,v  <--  l10n.list
new revision: 1.3; previous revision: 1.2

Integrated the diff into release41:
Checking in editor/l10n.list;
/cvs/editor/l10n.list,v  <--  l10n.list
new revision: 1.6.4.1; previous revision: 1.6
done
Checking in html/l10n.list;
/cvs/html/l10n.list,v  <--  l10n.list
new revision: 1.2.72.1; previous revision: 1.2
Comment 4 Miloslav Metelka 2005-04-04 20:17:33 UTC
Created attachment 21365 [details]
Diff of missing NOI18N in editor, html/editor and java/editor
Comment 5 Miloslav Metelka 2005-04-04 20:18:48 UTC
Fixed missing NOI18N in main trunk only:
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/BookmarksKitInstallAction.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/BookmarksKitInstallAction.java,v
 <--  BookmarksKitInstallAction.java
new revision: 1.3; previous revision: 1.2
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/GotoBookmarkAction.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/GotoBookmarkAction.java,v
 <--  GotoBookmarkAction.java
new revision: 1.2; previous revision: 1.1
done
Checking in
editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/ToggleBookmarkAction.java;
/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/ToggleBookmarkAction.java,v
 <--  ToggleBookmarkAction.java
new revision: 1.2; previous revision: 1.1
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/BookmarksXMLHandler.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/BookmarksXMLHandler.java,v
 <--  BookmarksXMLHandler.java
new revision: 1.3; previous revision: 1.2
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/EditorBookmarksModule.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/EditorBookmarksModule.java,v
 <--  EditorBookmarksModule.java
new revision: 1.2; previous revision: 1.1
done
Checking in
editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/FileBookmarks.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/FileBookmarks.java,v
 <--  FileBookmarks.java
new revision: 1.2; previous revision: 1.1
done
Checking in
editor/errorstripe/annotations/src/org/netbeans/modules/editor/errorstripe/annotations/AnnotationStatus.java;
/cvs/editor/errorstripe/annotations/src/org/netbeans/modules/editor/errorstripe/annotations/AnnotationStatus.java,v
 <--  AnnotationStatus.java
new revision: 1.3; previous revision: 1.2
done
Checking in
editor/errorstripe/src/org/netbeans/modules/editor/errorstripe/AnnotationView.java;
/cvs/editor/errorstripe/src/org/netbeans/modules/editor/errorstripe/AnnotationView.java,v
 <--  AnnotationView.java
new revision: 1.13; previous revision: 1.12
done
Checking in
editor/errorstripe/src/org/netbeans/modules/editor/errorstripe/spi/MarkProvider.java;
/cvs/editor/errorstripe/src/org/netbeans/modules/editor/errorstripe/spi/MarkProvider.java,v
 <--  MarkProvider.java
new revision: 1.3; previous revision: 1.2
done
Checking in
editor/errorstripe/src/org/netbeans/modules/editor/errorstripe/spi/Status.java;
/cvs/editor/errorstripe/src/org/netbeans/modules/editor/errorstripe/spi/Status.java,v
 <--  Status.java
new revision: 1.3; previous revision: 1.2
done
Checking in editor/libsrc/org/netbeans/editor/BaseDocument.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseDocument.java,v  <--  BaseDocument.java
new revision: 1.121; previous revision: 1.120
done
Checking in editor/libsrc/org/netbeans/editor/BaseDocumentEvent.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseDocumentEvent.java,v  <-- 
BaseDocumentEvent.java
new revision: 1.24; previous revision: 1.23
done
Checking in editor/libsrc/org/netbeans/editor/BaseKit.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseKit.java,v  <--  BaseKit.java
new revision: 1.132; previous revision: 1.131
done
Checking in editor/libsrc/org/netbeans/editor/CustomFoldManager.java;
/cvs/editor/libsrc/org/netbeans/editor/CustomFoldManager.java,v  <-- 
CustomFoldManager.java
new revision: 1.6; previous revision: 1.5
done
Checking in editor/libsrc/org/netbeans/editor/SettingsDefaults.java;
/cvs/editor/libsrc/org/netbeans/editor/SettingsDefaults.java,v  <-- 
SettingsDefaults.java
new revision: 1.55; previous revision: 1.54
done
Checking in editor/libsrc/org/netbeans/editor/ext/ExtKit.java;
/cvs/editor/libsrc/org/netbeans/editor/ext/ExtKit.java,v  <--  ExtKit.java
new revision: 1.58; previous revision: 1.57
done
Checking in editor/libsrc/org/netbeans/lib/editor/hyperlink/HyperlinkOperation.java;
/cvs/editor/libsrc/org/netbeans/lib/editor/hyperlink/HyperlinkOperation.java,v 
<--  HyperlinkOperation.java
new revision: 1.9; previous revision: 1.8
done
Checking in editor/src/org/netbeans/modules/editor/CustomizableSideBar.java;
/cvs/editor/src/org/netbeans/modules/editor/CustomizableSideBar.java,v  <-- 
CustomizableSideBar.java
new revision: 1.5; previous revision: 1.4
done
Checking in editor/src/org/netbeans/modules/editor/NbEditorUI.java;
/cvs/editor/src/org/netbeans/modules/editor/NbEditorUI.java,v  <--  NbEditorUI.java
new revision: 1.33; previous revision: 1.32
done
Checking in editor/src/org/netbeans/modules/editor/NbToolTip.java;
/cvs/editor/src/org/netbeans/modules/editor/NbToolTip.java,v  <--  NbToolTip.java
new revision: 1.14; previous revision: 1.13
done
Checking in
editor/src/org/netbeans/modules/editor/hyperlink/LayerHyperlinkProviderManager.java;
/cvs/editor/src/org/netbeans/modules/editor/hyperlink/LayerHyperlinkProviderManager.java,v
 <--  LayerHyperlinkProviderManager.java
new revision: 1.2; previous revision: 1.1
done
Checking in editor/src/org/netbeans/modules/editor/options/AnnotationTypesNode.java;
/cvs/editor/src/org/netbeans/modules/editor/options/AnnotationTypesNode.java,v 
<--  AnnotationTypesNode.java
new revision: 1.16; previous revision: 1.15
done
Checking in editor/src/org/netbeans/modules/editor/options/ScrollInsetsEditor.java;
/cvs/editor/src/org/netbeans/modules/editor/options/ScrollInsetsEditor.java,v 
<--  ScrollInsetsEditor.java
new revision: 1.10; previous revision: 1.9
done
Checking in
editor/util/src/org/netbeans/lib/editor/util/swing/DocumentListenerPriority.java;
/cvs/editor/util/src/org/netbeans/lib/editor/util/swing/DocumentListenerPriority.java,v
 <--  DocumentListenerPriority.java
new revision: 1.2; previous revision: 1.1
done
Checking in
html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java;
/cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v
 <--  HTMLCompletionQuery.java
new revision: 1.7; previous revision: 1.6
done
Checking in html/editor/lib/src/org/netbeans/editor/ext/html/HTMLSyntaxSupport.java;
/cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLSyntaxSupport.java,v 
<--  HTMLSyntaxSupport.java
new revision: 1.13; previous revision: 1.12
done
Checking in
html/editor/src/org/netbeans/modules/editor/html/javadoc/HelpManager.java;
/cvs/html/editor/src/org/netbeans/modules/editor/html/javadoc/HelpManager.java,v
 <--  HelpManager.java
new revision: 1.6; previous revision: 1.5
done
Checking in
html/editor/src/org/netbeans/modules/editor/html/javadoc/SAXHelpHandler.java;
/cvs/html/editor/src/org/netbeans/modules/editor/html/javadoc/SAXHelpHandler.java,v
 <--  SAXHelpHandler.java
new revision: 1.3; previous revision: 1.2
done
Checking in
html/editor/src/org/netbeans/modules/editor/html/javadoc/TagHelpItem.java;
/cvs/html/editor/src/org/netbeans/modules/editor/html/javadoc/TagHelpItem.java,v
 <--  TagHelpItem.java
new revision: 1.3; previous revision: 1.2
done
Checking in
html/editor/src/org/netbeans/modules/html/editor/folding/HTMLFoldManager.java;
/cvs/html/editor/src/org/netbeans/modules/html/editor/folding/HTMLFoldManager.java,v
 <--  HTMLFoldManager.java
new revision: 1.19; previous revision: 1.18
done
Checking in
html/editor/src/org/netbeans/modules/html/editor/folding/HTMLFoldUtils.java;
/cvs/html/editor/src/org/netbeans/modules/html/editor/folding/HTMLFoldUtils.java,v
 <--  HTMLFoldUtils.java
new revision: 1.4; previous revision: 1.3
done
Checking in java/editor/lib/src/org/netbeans/editor/ext/java/JavaSettingsNames.java;
/cvs/java/editor/lib/src/org/netbeans/editor/ext/java/JavaSettingsNames.java,v 
<--  JavaSettingsNames.java
new revision: 1.3; previous revision: 1.2
done
Checking in
java/editor/src/org/netbeans/modules/editor/java/FixDuplicateImportStmts.java;
/cvs/java/editor/src/org/netbeans/modules/editor/java/FixDuplicateImportStmts.java,v
 <--  FixDuplicateImportStmts.java
new revision: 1.7; previous revision: 1.6
done
Checking in java/editor/src/org/netbeans/modules/editor/java/JMIUtils.java;
/cvs/java/editor/src/org/netbeans/modules/editor/java/JMIUtils.java,v  <-- 
JMIUtils.java
new revision: 1.29; previous revision: 1.28
done

Setting TM to 4.2 as NOI18N fixes only go to 4.2.
Comment 6 Miloslav Metelka 2005-04-07 12:43:52 UTC
Additional fix - editor/libsrc was not covered by the generic rule.
Fixed in main trunk
Checking in l10n.list;
/cvs/editor/l10n.list,v  <--  l10n.list
new revision: 1.8; previous revision: 1.7
Comment 7 Jan Becicka 2005-12-09 09:39:14 UTC
Verified.