Bug 53539 - ModuleChangeDescriptor should provide list of all changed files
ModuleChangeDescriptor should provide list of all changed files
Status: RESOLVED FIXED
Product: serverplugins
Classification: Unclassified
Component: Infrastructure
4.x
PC Linux
: P1 (vote)
: TBD
Assigned To: Nam Nguyen
issues@serverplugins
: API_REVIEW_FAST
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-18 08:17 UTC by Nam Nguyen
Modified: 2009-02-13 20:00 UTC (History)
4 users (show)

See Also:
Issue Type: ENHANCEMENT
:


Attachments
Adding ModuleChangeDescriptor.getChangedFiles (4.36 KB, patch)
2005-01-18 17:33 UTC, Nam Nguyen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nam Nguyen 2005-01-18 08:17:09 UTC
Currently ModuleChangeDescriptor only provide the
following types of change: deployment descriptor,
server-specific descriptor, classes, manifest. 
This prove to be insufficient and in the past year
for more than once we had to update the list of
file suffixes to check for changes.  There is no
reason for not providing plugin with all the list
of file changes as proposed following:

ModuleChangeDescriptor {

   /**
    * Returns list of relative paths of changed files.
    */ 
   File[] getChangedFiles();
}

This is a compatible change. 
ModuleChangeDescriptor is implemented by
deployment code in j2eeserver and the new method
getChangedFiles would only be used by plugin code
when all the existing methods are not sufficient
to address some server specific corner cases.
Comment 1 Nam Nguyen 2005-01-18 08:21:29 UTC
This is trivial and compatible change.
Comment 2 Nam Nguyen 2005-01-18 17:33:15 UTC
Created attachment 19757 [details]
Adding ModuleChangeDescriptor.getChangedFiles
Comment 3 Nam Nguyen 2005-01-18 17:34:53 UTC
Diffs of apichanges.xml, ModuleChangeDescriptor, ServerFileDistributor
are included.
Comment 4 Nam Nguyen 2005-01-19 22:03:04 UTC
Proposed changes checked in:

/cvs/j2eeserver/apichanges.xml,v  <--  apichanges.xml
new revision: 1.8; previous revision: 1.7
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerFileDistributor.java,v
 <--  ServerFileDistributor.java
new revision: 1.19; previous revision: 1.18
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/ModuleChangeDescriptor.java,v
 <--  ModuleChangeDescriptor.java
new revision: 1.4; previous revision: 1.3
Comment 5 Vince Kraemer 2009-02-13 20:00:29 UTC
this must have been missed


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo