This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 53171 - Add method getType() into org.netbeans.spi.vcs.VcsCommandsProvider class.
Summary: Add method getType() into org.netbeans.spi.vcs.VcsCommandsProvider class.
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 4.x
Hardware: All All
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 41425
  Show dependency tree
 
Reported: 2005-01-10 16:34 UTC by Martin Entlicher
Modified: 2006-03-24 12:46 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
The diff of proposed API change. (772 bytes, patch)
2005-01-10 16:35 UTC, Martin Entlicher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Entlicher 2005-01-10 16:34:05 UTC
In order to fix issue #41425, we need to have the
identity of the commands provider so that we can
store the default values of command options for
the appropriate version control system.

That method can be used also in other cases when
it's necessary to identify the given VCS type.

The suggested change is attached...
Comment 1 Martin Entlicher 2005-01-10 16:35:41 UTC
Created attachment 19584 [details]
The diff of proposed API change.
Comment 2 Jaroslav Tulach 2005-01-12 10:01:29 UTC
Update apichanges.xml, increase spec. version, use @since tag,  
update javadoc to describe how the method should be used. Write test 
- probably showing that the default values are kept as they should. 
  
Comment 3 Martin Entlicher 2005-01-18 11:07:58 UTC
Thanks for comments, working on it...
Comment 4 Martin Entlicher 2005-01-18 11:09:20 UTC
Fixed in trunk:

/cvs/vcscore/api/doc/changes/apichanges.xml,v  <--  apichanges.xml
new revision: 1.4; previous revision: 1.3

/cvs/vcscore/src/org/netbeans/spi/vcs/VcsCommandsProvider.java,v  <--
 VcsCommandsProvider.java
new revision: 1.4; previous revision: 1.3

/cvs/vcscore/manifest.mf,v  <--  manifest.mf
new revision: 1.54; previous revision: 1.53
Comment 5 Peter Pis 2005-06-23 16:14:17 UTC
Verified.