This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Modify sun-cmp-mappings content instead of sun-ejb-jar.xml using the sun-specific editor. Now quit the IDE. You will see sun-ejb-jar.xml listed in the unsaved files, but not sun-cmp-mappings.
With the current code, both files are shown in the exit dialog. So the current behavior is like this. Change in any part, even the changed properties are stored in one of the config file, all files (DataObjbect's) are shown as need save. This is because the config editor and the underlygin ConfigurationStorage is designed to represents all configuration files as a whole. In the config editor there is no indications about from which file the config properties came from. To indicate accurately which file needs save, we would needs additional SPI for plugin to tell j2eeserver the config descriptor file a DConfigBean instance belongs to. Something like: ConfigurationSupport { String getDeploymentPlanFileFor(DConfigBean configBean); } I guess this is not a high priority and would leave this at P3.
Is this new behavior? I have a build from last night and only see sun-ejb-jar.xml in the exit dialog.
The checkin was 2004/12/20 around 17:54 (I guess PST).
I updated my build again and now I have seen both ways in the same build. I'm not sure exactly what the difference is, but sun-ejb-jar.xml always shows up in the list while sun-cmp-mappings does sometimes. Also, I tried to close the project with mods to sun-cmp-mappings and only see sun-ejb-jar.xml. So I think there are still both problems here.
I think this is worse now - I only see save (menu) enabled on sun-ejb-jar, not sun-cmp-mappings. I only see sun-ejb-jar in the Save/Discard/Cancel dialog and in the saved files dialog on close project/exit. However, both files, do get saved.
OK, I can then change the standard "File sun-ejb-jar.xml is modified. Save it?" dialog to "Files sun-ejb-jar.xml, sun-cmp-mappings.xml are modified. Save them?" Do you agree? I agree that the sun-cmp-mappings.xml should be also displayed in the save files dialog on close project/exit. Setting TM to 4.1.
Maybe it should say Sun Configuration Files have changed. Sometimes only one is edited, sometimes both. I'm not sure if you're able to tell which case it is. See issue 53030: If you change the editor tab name, I think the file save dialog message will come from there.
> I'm not sure if you're able to tell which case it is. No, I'm not. It would require an API change as Nam already pointed out. I agree that the save message should correspond with the editor tab name.
this should be now fixed in the sunappserv plugin
looks like this got shunted to us based on the j2eeserver api changes.
Fixed. Now says "sun-ejb-jar.xml / sun-cmp-mappings.xml" on editor tab. It would be nice if this was really dynamic and only included the cmp-mappings part if that file either existed or was going to exist, but that is lots of work for very little gain. Not worth it IMO, especially since we are revamping entire framework in next version.
I just tried in NB 5 Beta 2: open the config editor editor tab has the new name with both files listed - good make a change to consistency level for a bean (lives in sun-cmp-mappings data) editor tab name changes to "sun-ejb-jar.xml*" - wrong name click on the close icon in the editor tab - warning is only about sun-ejb-jar - wrong name I didn't try to exit the ide, but the 2 steps above indicate that the fix is not complete yet.
I had to exit the ide anyway, so I saw that it identifies on sun-ejb-jar.xml as changed in that dialog, when in fact only sun-cmp-mappings has changes.
I also noticed that the tooltip points to the location of the sun-ejb-jar.xml (only) even when the tab name lists both files.
To be fair, the fact we have 2 files instead of one is more a design issue with the Sun App server that the IDE. Netbeans tries to hide the DD files as much as possible. Exposing more and more that for Sun App server we have 2 DD files is the wrong direction. P4 for netbeans. Maybe p2 for the CMP area of the app server, imo.
Agree that this is P4. However, for correctness: Currently, it is only practical to group both files together for all messages, regardless of where the actual changes are reflected.
For messages, okay that they're both mentioned. But in the exit dialog, the files are listed as nodes with a save button that can be enabled/disabled based on which nodes are selected. In that case, I expect only the edited files to be mentioned.
TM 5.0->TBD
Fixed by virtue of new design. sun-ejb-jar.xml and sun-cmp-mappings.xml are now independent editors.