This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 51638 - CvsUpdateVisualizer causes OOME
Summary: CvsUpdateVisualizer causes OOME
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 4.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-18 13:26 UTC by _ pkuzel
Modified: 2006-03-24 09:48 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
The patch. (2.53 KB, patch)
2004-11-18 14:46 UTC, Martin Entlicher 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ pkuzel 2004-11-18 13:26:46 UTC 
It incorrectly contruct file names resulting in
pearls like "CVSROOT/CVSROOT/ (10times)
/a11y/CVSROOT/ (9 times) ....". These strings
exhaust all available memory very soon even for
mid-sided checkouts.
Comment 1 Martin Entlicher 2004-11-18 13:29:46 UTC 
The problem found in CvsUpdateVisualizer. The problem is, that
checkout reports the whole path instead of just a file name.
Comment 2 Martin Entlicher 2004-11-18 14:44:47 UTC 
Fixed in trunk:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/update/CvsUpdateVisualizer.java,v
 <--  CvsUpdateVisualizer.java
new revision: 1.17; previous revision: 1.16

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/update/CvsUpdateVisualizerStdOut.java,v
 <--  CvsUpdateVisualizerStdOut.java
new revision: 1.4; previous revision: 1.3
Comment 3 Martin Entlicher 2004-11-18 14:46:32 UTC 
Created attachment 18955 [details]
The patch.
Comment 4 Jan Chalupa 2004-11-18 15:19:34 UTC 
Please send a notice to reviewers@netbeans.org and prepare a fix for 4.0.
Comment 5 _ pkuzel 2004-11-18 16:01:34 UTC 
I have looked on and tested the patch without problems.
Comment 6 Peter Pis 2004-11-19 09:23:50 UTC 
I think this a duplicate of #51451.
Comment 7 Peter Pis 2004-11-19 12:50:24 UTC 
Verified in NB 200411181900.
Comment 8 Martin Entlicher 2004-11-19 15:36:21 UTC 
Thanks for the review and verification. The fix is merged into
release40 branch:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/update/CvsUpdateVisualizer.java,v
 <--  CvsUpdateVisualizer.java
new revision: 1.13.22.2; previous revision: 1.13.22.1

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/update/CvsUpdateVisualizerStdOut.java,v
 <--  CvsUpdateVisualizerStdOut.java
new revision: 1.2.4.2; previous revision: 1.2.4.1