This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Please tweak the appearance of the main toolbar in win classic L&F according to the UI spec. The difference between the implementation and specification includes (pointed out in the attached image): 1) Implementation: No left etched border is in the main toolbar. Specification: An etched border is around the whole main toolbar. 2) Implementation: No right etched border in the main toolbar. Specification: An etched border is around the whole main toolbar. 3) Implementation: A heavy bottom border in the main toolbar. Specification: An etched border is around the whole main toolbar. 4) Implementation: A double drag texture is in the main toolbar. Specification: A single drag texture is in the main toolbar.
Created attachment 17209 [details] Toolbar bugs in win classic L&F.
Passing to Stan.
Created attachment 17760 [details] Bug fix
dafe, review my bugfix pls
Yes, patch looks OK, but what about isXPTheme method? It looks like you copied it from somewhere, didn't you? IMO it would be better to just call some shared public static impl of this method. If this is not possible for some reason, note that in javadoc please. Thx.
i couldn't reuse the ixXPTheme method because it is declared private. i added a note to javadoc.
Verified in NetBeans 4.2 Build 200507181000, JDK 1.6.0-ea