This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 47625 - [40cat] renaming of properties should rename getters and setters too
Summary: [40cat] renaming of properties should rename getters and setters too
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker with 5 votes (vote)
Assignee: Jan Becicka
URL:
Keywords:
: 49223 50924 55515 56255 59476 64787 88017 96104 150632 (view as bug list)
Depends on:
Blocks: 100758
  Show dependency tree
 
Reported: 2004-08-21 07:56 UTC by _ leonchiver
Modified: 2011-10-20 09:09 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ leonchiver 2004-08-21 07:56:48 UTC
[ JDK VERSION : J2SE 1.5.0 ]

or at least it should ask it.

if i rename the getter, IDE should ask about the setter and the property

if i rename the setter, IDE should ask about the getter and property

if i rename the property, IDE should ask about
the getter and setter.

i always have to do 3 renamings.
Comment 1 Martin Matula 2004-11-11 16:05:07 UTC
*** Issue 49223 has been marked as a duplicate of this issue. ***
Comment 2 Jan Becicka 2005-05-20 09:51:06 UTC
*** Issue 55515 has been marked as a duplicate of this issue. ***
Comment 3 Jan Becicka 2005-05-20 09:55:01 UTC
*** Issue 56255 has been marked as a duplicate of this issue. ***
Comment 4 Jan Becicka 2005-05-20 10:04:42 UTC
*** Issue 52044 has been marked as a duplicate of this issue. ***
Comment 5 athompson 2005-05-20 18:42:50 UTC
*** Issue 50924 has been marked as a duplicate of this issue. ***
Comment 6 Jan Becicka 2005-06-02 09:51:38 UTC
*** Issue 59476 has been marked as a duplicate of this issue. ***
Comment 7 mdm42 2005-11-13 08:44:05 UTC
*** Issue 64787 has been marked as a duplicate of this issue. ***
Comment 8 omaskara 2006-01-07 21:56:26 UTC
Just like me, but I rename the parameter name too.
Comment 9 mikeskells 2006-01-08 07:53:29 UTC
It should rename the parameter, 
also do some rework on the javadoc
comments should be able to be re-worked as well

for overriding classes there should be options to do the same as the above
either 

there should also be an option to rename the formal parameter for overriding 
classes
Comment 10 mikeskells 2006-01-08 07:55:45 UTC
try that last comment again ----

It should rename the parameter, 
also do some rework on the javadoc
comments should be able to be re-worked as well

for overriding classes there should be options to do the same as the above
either 
    always
    never
    if the parameter formal name matches the old name of the parameter
Comment 11 Jiri Prox 2008-10-20 10:44:10 UTC
*** Issue 96104 has been marked as a duplicate of this issue. ***
Comment 12 Jiri Prox 2008-10-20 10:49:00 UTC
*** Issue 150632 has been marked as a duplicate of this issue. ***
Comment 13 Jan Becicka 2011-05-26 10:54:41 UTC
Changeset: http://hg.netbeans.org/jet-main/rev/63ace3ed3141
Author:    Jan Becicka <jbecicka@netbeans.org>
Date:      2011-05-26 12:48
Message:   
Issue #47625 - [40cat] renaming of properties should rename getters and setters too
Comment 14 Quality Engineering 2011-05-27 11:54:08 UTC
Integrated into 'main-golden', will be available in build *201105270401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/63ace3ed3141
User: Jan Becicka <jbecicka@netbeans.org>
Log: Issue #47625 - [40cat] renaming of properties should rename getters and setters too
Comment 15 athompson 2011-05-31 19:39:24 UTC
If in the 'rename' dialog you check "Rename Getter and Setter" *before* you change the name, it renames the getter and setter incorrectly.
Comment 16 Jan Becicka 2011-06-01 08:33:46 UTC
Changeset: http://hg.netbeans.org/jet-main/rev/a7224a10208b
Author:    Jan Becicka <jbecicka@netbeans.org>
Date:      2011-06-01 10:27
Message:   
Issue #47625 - [40cat] renaming of properties should rename getters and setters too
Comment 17 Quality Engineering 2011-06-02 21:05:58 UTC
Integrated into 'main-golden', will be available in build *201106021001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/a7224a10208b
User: Jan Becicka <jbecicka@netbeans.org>
Log: Issue #47625 - [40cat] renaming of properties should rename getters and setters too
Comment 18 athompson 2011-06-03 18:37:20 UTC
Looks good to me.  Is it bad etiquette to mark someone else's bug as verified?  The original guy may not be around any more.  :)
Comment 19 vanob 2011-06-04 11:10:29 UTC
I've verified and it works.

The only concern is that when you click "Rename setter and getter" checkbox in the dialog, IDE thinks about a second or two before changing state.
Comment 20 Jan Becicka 2011-06-06 05:36:04 UTC
Are you able to take thread dump during those 2s?
Comment 21 Ralph Ruijs 2011-10-20 09:09:53 UTC
*** Bug 88017 has been marked as a duplicate of this bug. ***