This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 47575 - xml/xsl dependency on libs/xalan
Summary: xml/xsl dependency on libs/xalan
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: Code (show other bugs)
Version: 4.x
Hardware: All All
: P1 blocker (vote)
Assignee: Michal Zlamal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-20 17:01 UTC by Jan Lahoda
Modified: 2006-03-24 10:30 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lahoda 2004-08-20 17:01:09 UTC
(nbbuild/build.xml revision 1.544).
The xml/xsl module needs the xalan external binary
to be installed under the netbeans folder (at
correct place) before it starts to compile. This
was assured by dependency on libs/xalan
(all-libs/xalan). But, this dependency was removed
by commit of revision 1.542.

Without this dependency, the libs/xalan module is
built before the xml/xsl module on some computers,
but on others, the xml/xsl module is built before
the libs/xalan module and the build simply fails.

So, it is necessary to assure that the libs/xalan
module will be built before the xml/xsl module or
otherwise assure that the correct binary will be
accessible by the build script of xml/xsl.
Comment 1 Michal Zlamal 2004-08-20 19:32:44 UTC
So why the CB works without any problems? - no libs/xalan module compile.

BTW: If there is dependenchy of xml/xsl module on libs/xalan module, why the libs/
xalan module isn't listed in nbbuild/build.properites and nbbuild/cluster.properties?
Comment 2 Jesse Glick 2004-08-20 19:43:09 UTC
Just because C/B is running does not mean the build script is correct
- it just means we are lucky in that the particular set of modules
currently being built does not trigger the bug. (But running e.g.
all-xml/xsl *could*.)
Comment 3 Michal Zlamal 2004-08-20 19:55:19 UTC
Jesse, I know it, I wasn't able to find the "libs/xalan" find in the log, so I assume that the 
all-libs/xalan target wasn't run... 
BTW: The disabling of run of libs/xalan target was intention of my integration.
Comment 4 _ pkuzel 2004-08-23 08:23:13 UTC
JRE 1.5 does NOT contain Xalan. It's repackaged.
Comment 5 Michal Zlamal 2004-08-23 09:11:50 UTC
Than it is bug of XML module, because xml/xalan module is not part of 
build, if it should be added then I can do that, but until that, there 
can't be such dependency.
Comment 6 _ pkuzel 2004-08-23 09:48:53 UTC
revision 1.16
date: 2004/05/19 12:19:38;  author: rkubacki;  state: Exp;  lines: +0 -2
#38300, #34593: deprecating libs/jaxp and removing it together with
libs/xalan from build

Index: manifest.mf
===================================================================
RCS file: /cvs/xml/xsl/manifest.mf,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -b -r1.15 -r1.16
--- manifest.mf 16 Mar 2004 15:37:51 -0000      1.15
+++ manifest.mf 19 May 2004 12:19:38 -0000      1.16
@@ -10,8 +10,6 @@
 OpenIDE-Module-Module-Dependencies:
  org.netbeans.api.xml/1 > ${xml.api.spec.version},
  org.netbeans.modules.xml.core/2 = ${xml.common.impl.version},
- org.netbeans.libs.jaxp/1,
- org.netbeans.libs.xalan/1 > 1.1,
  org.netbeans.modules.servletapi/1,
  org.openide.execution > 1.2
 OpenIDE-Module-Requires: org.openide.util.HttpServer$Impl

This is in error. org.netbeans.libs.xalan/1 dependency must not be
removed.
Comment 7 Milan Kuchtiak 2004-08-23 17:45:25 UTC
I set back the dependency on libs/xalan :

http://xml.netbeans.org/source/browse/xml/xsl/manifest.mf.diff?r1=1.18&r2=1.19

However, we should get rid of the dependency on Xalan in order to make
product smaller (and faster).

See the enhancement :
issue 47724
Comment 8 _ rkubacki 2004-08-24 08:10:21 UTC
Following commits are also part of the fix -

2004-08-23 12:56  mzlamal

	* nbbuild/: build.properties, build.xml, cluster.properties:
	 Add libs/xalan to build, fix dependencies of xml/xsl module
Comment 9 dmladek 2004-08-26 14:27:02 UTC
Honzo, can you verify it, please?
Comment 10 Jan Lahoda 2004-08-27 07:39:14 UTC
I am able to build NB -> OK.